Repository navigation
gh-131798: JIT: Split CALL_STR_1 into several uops - #132849
Merged
brandtbucher merged 6 commits intoApr 24, 2025
Merged
brandtbucher merged 6 commits into
brandtbucher merged 6 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
tomasr8
commented
Apr 24, 2025
Comment thread
Python/optimizer_bytecodes.c
Comment on lines
+859
to
+863
| if (sym_matches_type(arg, &PyUnicode_Type)) { | ||
| // e.g. str('foo') or str(foo) where foo is known to be a string | ||
| PyObject *value = sym_get_const(ctx, arg); | ||
| res = sym_new_const(ctx, value); | ||
| } |
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment.
This is an optimization that Brandt suggested. When in str(foo), foo is known to be a string, we can propagate it to the output. I also added a test for this case.
Sorry, something went wrong.
brandtbucher
approved these changes
Apr 24, 2025
brandtbucher
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Looks great! Just two suggestions:
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Thanks for the review! |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CALL_STR_1 is equivalent to str(...).
Very similar to previous work on splitting up CALL_TYPE_1: #132419
This splits the instruction into a smaller instruction + 2 guards which can be optimized away. This also sets the return type to str.