FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

GH-133171: Prevent combinations of `--disable-gil` and `--enable-experimental-jit` (for now) by brandtbucher · Pull Request #133179 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

GH-133171: Prevent combinations of --disable-gil and --enable-experimental-jit (for now) - #133179

Merged
brandtbucher merged 4 commits into
python:mainfrom
brandtbucher:nogil-means-nojit
May 2, 2025
ConversationCommits (4)ChecksFiles changed
Merged

GH-133171: Prevent combinations of --disable-gil and --enable-experimental-jit (for now)#133179
brandtbucher merged 4 commits into
python:mainfrom
brandtbucher:nogil-means-nojit

Conversation

brandtbucher commented Apr 30, 2025 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

...I do not think it means what you think it means.

brandtbucher added build The build process and cross-build topic-free-threading topic-JIT labels Apr 30, 2025
brandtbucher self-assigned this Apr 30, 2025
bedevere-app Bot mentioned this pull request Apr 30, 2025
Open
1 of 7 tasks
brandtbucher changed the title GH-133171: Prevent combinations of --disable-gil *and* --enable-experimental-jit (for now) GH-133171: Prevent combinations of --disable-gil and --enable-experimental-jit (for now) Apr 30, 2025

brandtbucher commented Apr 30, 2025

Copy link
Copy Markdown
Member Author

Probably gonna conflict with GH-131751. @savannahostrowski, you can land that one first.

zooba reviewed Apr 30, 2025
View reviewed changes
Comment thread PCbuild/build.bat
)
)

if "%UseDisableGil%" EQU "true" if "%UseTIER2%" NEQ "" (

zooba Apr 30, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Strictly speaking this would be better as target in pythoncore.vcxproj (see the existing _WarnAboutZlib for example), since there's no requirement to use the batch file, and it's very easy to bypass it. (The same goes for the PGO warning above, I don't remember when that was added.)

But it's not a big deal. It's relatively temporary code anyway

brandtbucher May 2, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Yeah, this will only be around for 3.14. I could just put an #error in the C source or whatever, but I figure failing early is best.

Besides, it's not like there's anything wrong with enabling both features. It just doesn't work the way you'd expect.

brandtbucher merged commit 2da48e3 into python:main May 2, 2025
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
pythonGH-133171: Prevent combinations of --disable-gil and --enable-e…
abf043b 
…xperimental-jit... for now (pythonGH-133179)
corona10 mentioned this pull request Aug 15, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

zooba zooba left review comments
savannahostrowski Awaiting requested review from savannahostrowski
erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland is a code owner
corona10 Awaiting requested review from corona10 corona10 is a code owner

Assignees

brandtbucher

Labels

build The build process and cross-build topic-free-threading topic-JIT

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL