| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
|
@savannahostrowski @diegorusso @Fidget-Spinner @brandtbucher To the JIT team — I’m not sure who’s currently working on this, but it might be a good starting point to add JIT support. My next goal will be to make the tier-two instructions thread-safe. |
Sorry, something went wrong.
|
I think we should start by running the tests in CI for JIT+FT current build and see what passes/fails before doing this |
Sorry, something went wrong.
We disabled FT + JIT build from #133179 do you think that we have to listing the current status? |
Sorry, something went wrong.
This makes sense but actually the default build's JIT can't even run with the optimizer turned off! There's some segfaults when we turn off the optimizer lol. |
Sorry, something went wrong.
How can I trigger this? |
Sorry, something went wrong.
Run the test suite with PYTHON_UOPS_OPTIMIZE=0 env var. |
Sorry, something went wrong.
Just for the record at default build: 39 tests failed:
test.test_asyncio.test_pep492
test.test_multiprocessing_forkserver.test_processes
test.test_multiprocessing_spawn.test_processes test_array test_bdb
test_buffer test_code test_codecmaps_cn test_codecmaps_hk
test_codecmaps_jp test_codecmaps_kr test_codecmaps_tw
test_collections test_complex test_datetime test_embed test_float
test_htmlparser test_idle test_import test_json test_long
test_math test_patma test_peepholer test_pickle test_pow
test_random test_scope test_slice test_ssl test_struct
test_sys_settrace test_tarfile test_threading test_time test_trace
test_zipimport_support test_zoneinfo
|
Sorry, something went wrong.
|
Ah never mind, it need to be transformed tier 2 code first. |
Sorry, something went wrong.
|
@Fidget-Spinner @brandtbucher I noticed that JIT x FT still doesn’t build even with the entire optimizer path disabled, so fix it temporarily. I’ve added a direct fallback to Tier 1; it’s slow, but fine for now. Let’s re-enable _PyOptimizer_Optimize step by step. To do that, we also need to re-enable CI (just for build testing) |
Sorry, something went wrong.
|
cc @savannahostrowski Once this PR is merged, others can start collaborating on the full FT x JIT work separately. |
Sorry, something went wrong.
| static inline int | ||
| PyStackRef_RefcountOnObject(_PyStackRef ref) | ||
| { | ||
| return (ref.bits & Py_TAG_REFCNT) == 0; |
There was a problem hiding this comment.
I think this implementation is fine, but I'm not 100% sure
Sorry, something went wrong.
|
If there are no major objections to this PR, I am going to merge this PR (maybe next week) |
Sorry, something went wrong.
| } | ||
|
|
||
| static inline int | ||
| PyStackRef_RefcountOnObject(_PyStackRef ref) |
There was a problem hiding this comment.
Just personal interest, correct me if I'm wrong.
It seems we don;t call this function yet right? Is this prepared for a future hook?
This function seems be trigger at
Sorry, something went wrong.
There was a problem hiding this comment.
It seems we don;t call this function yet right? Is this prepared for a future hook?
Yeah correct, but we can't build if this function is not added. That's all at this moment.
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.