FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-134036: Improve error messages for invalid `raise` statements by sobolevn · Pull Request #134077 · python/cpython · GitHub

/ cpython Public

gh-134036: Improve error messages for invalid raise statements - #134077

Merged
pablogsal merged 1 commit into
python:mainfrom
sobolevn:issue-134036
Jun 6, 2025
ConversationCommits (1)ChecksFiles changed
Merged

gh-134036: Improve error messages for invalid raise statements#134077
pablogsal merged 1 commit into
python:mainfrom
sobolevn:issue-134036

Conversation

sobolevn commented May 16, 2025 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

Better error message wordings are welcome!

bedevere-app Bot mentioned this pull request May 16, 2025
Closed
lysnikolaou approved these changes Jun 5, 2025
View reviewed changes

lysnikolaou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM! It's simple enough that shouldn't create any problems and it is a clear improvement.

pablogsal commented Jun 6, 2025

Copy link
Copy Markdown
Member

Great improvement! ❤️

pablogsal merged commit 0d9ccc8 into python:main Jun 6, 2025

Wulian233 commented Jun 6, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

@pablogsal @sobolevn this commit causes all the latest PR test checks to fail, such as #135002 #131796 and #135198 .

It's all because of the

1 test failed:
test_syntax

Yhg1s commented Jun 6, 2025

Copy link
Copy Markdown
Member

I think this passed pre-merge CI but failed post-merge because rebasing it is what broke it... We can roll this back or it can be fixed-forward. If this can't be fixed quickly it should be rolled back. (/cc @hugovk.)

erlend-aasland mentioned this pull request Jun 6, 2025
Merged

vstinner commented Jun 6, 2025

Copy link
Copy Markdown
Member

I wrote #135204 to update test_syntax, the fix is trivial (update error messages).

picnixz mentioned this pull request Jun 14, 2025
Closed
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
pythongh-134036: Improve error messages for invalid raise statements (
9aa467f 
python#134077)
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
pythongh-134036: Improve error messages for invalid raise statements (
c98fc9c 
python#134077)
Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull request Aug 19, 2025
pythongh-134036: Improve error messages for invalid raise statements (
58453c1 
python#134077)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

pablogsal pablogsal approved these changes
lysnikolaou lysnikolaou approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL