FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-135001: Explicitly specify the encoding parameter value of `calendar.HTMLCalendar` as 'utf-8' by Wulian233 · Pull Request #135002 · python/cpython · GitHub

/ cpython Public

gh-135001: Explicitly specify the encoding parameter value of calendar.HTMLCalendar as 'utf-8' - #135002

Merged
vstinner merged 7 commits into
python:mainfrom
Wulian233:calendar
Jun 9, 2025
Merged

gh-135001: Explicitly specify the encoding parameter value of calendar.HTMLCalendar as 'utf-8'#135002
vstinner merged 7 commits into
python:mainfrom
Wulian233:calendar

Conversation

Wulian233 commented Jun 1, 2025
edited
Loading

Copy link
Copy Markdown
Contributor

Wulian233 changed the title gh-135001: Change the default parameter value of calendar.HTMLCalendar to utf-8 gh-135001: Change the default encoding parameter value of calendar.HTMLCalendar to utf-8 Jun 1, 2025
Comment thread Lib/calendar.py
Comment thread Doc/whatsnew/3.15.rst Outdated
picnixz marked this pull request as draft June 1, 2025 12:07

picnixz commented Jun 1, 2025

Copy link
Copy Markdown
Member

Making it a draft as it's a WIP.

Wulian233 marked this pull request as ready for review June 1, 2025 13:00
Wulian233 requested a review from picnixz June 1, 2025 13:39
picnixz previously requested changes Jun 2, 2025
Comment thread Lib/test/test_calendar.py
Comment thread Lib/calendar.py

bedevere-app Bot commented Jun 2, 2025

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

Copy link
Copy Markdown
Contributor Author

The new commit resolves the above review and requires you to confirm that it is resolved. Thanks!

I have made the requested changes; please review again

bedevere-app Bot commented Jun 2, 2025

Copy link
Copy Markdown

Thanks for making the requested changes!

@picnixz: please review the changes made to this pull request.

bedevere-app Bot requested a review from picnixz June 2, 2025 08:38
Comment thread Doc/library/calendar.rst Outdated
Comment thread Doc/library/calendar.rst Outdated
Comment thread Doc/library/calendar.rst Outdated
Comment thread Doc/library/calendar.rst Outdated
Comment thread Doc/whatsnew/3.15.rst Outdated
Comment thread Doc/whatsnew/3.15.rst Outdated
Comment thread Lib/calendar.py

vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

sys.getdefaultencoding() always returns "utf-8", so this PR doesn't change the default encoding. If you want, you can replace sys.getdefaultencoding() with "utf-8". But I don't think that it should be documented.

Comment thread Lib/test/test_calendar.py
Wulian233 changed the title gh-135001: Change the default encoding parameter value of calendar.HTMLCalendar to utf-8 gh-135001: Explicitly specify the encoding parameter value of calendar.HTMLCalendar as 'utf-8' Jun 6, 2025

Copy link
Copy Markdown
Contributor Author

sys.getdefaultencoding() always returns "utf-8", so this PR doesn't change the default encoding. If you want, you can replace sys.getdefaultencoding() with "utf-8". But I don't think that it should be documented.

I just using git reset was not the right thing to do, and I apologize for that. I honestly didn’t consider this at the time

I’ve added a news entry, do you think that’s necessary?

vstinner commented Jun 6, 2025

Copy link
Copy Markdown
Member

I’ve added a news entry, do you think that’s necessary?

I don't think that it's necessary.

vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

vstinner commented Jun 9, 2025

Copy link
Copy Markdown
Member

test_syntax was failing on the CI. I updated the branch to try to repair the CI.

vstinner merged commit f90483e into python:main Jun 9, 2025

vstinner commented Jun 9, 2025

Copy link
Copy Markdown
Member

Merged, thanks.

Wulian233 deleted the calendar branch June 9, 2025 13:51
lkollar pushed a commit to lkollar/cpython that referenced this pull request Jun 19, 2025
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull request Aug 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL