| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
|
Making it a draft as it's a WIP. |
Sorry, something went wrong.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request. |
Sorry, something went wrong.
|
The new commit resolves the above review and requires you to confirm that it is resolved. Thanks! I have made the requested changes; please review again |
Sorry, something went wrong.
|
Thanks for making the requested changes! @picnixz: please review the changes made to this pull request. |
Sorry, something went wrong.
There was a problem hiding this comment.
sys.getdefaultencoding() always returns "utf-8", so this PR doesn't change the default encoding. If you want, you can replace sys.getdefaultencoding() with "utf-8". But I don't think that it should be documented.
Sorry, something went wrong.
I just using git reset was not the right thing to do, and I apologize for that. I honestly didn’t consider this at the time I’ve added a news entry, do you think that’s necessary? |
Sorry, something went wrong.
I don't think that it's necessary. |
Sorry, something went wrong.
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
|
test_syntax was failing on the CI. I updated the branch to try to repair the CI. |
Sorry, something went wrong.
|
Merged, thanks. |
Sorry, something went wrong.
…calendar.HTMLCalendar` as 'utf-8' (python#135002)
…calendar.HTMLCalendar` as 'utf-8' (python#135002)
…calendar.HTMLCalendar` as 'utf-8' (python#135002)
…calendar.HTMLCalendar` as 'utf-8' (python#135002)
| Back | FazBrowse Home | New Git URL |
📚 Documentation preview 📚: https://cpython-previews--135002.org.readthedocs.build/