FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-130655: add tests for dgettext by alex-semenyuk · Pull Request #134594 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-130655: add tests for dgettext #134594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alex-semenyuk wants to merge 4 commits into from
+22 −0
Conversation 17 Commits 4 Checks 0 Files changed 1
Closed

gh-130655: add tests for dgettext #134594

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
16165b5
gh-134593: add tests for dgettext
alex-semenyuk May 23, 2025
c4fb7ac
fix comments
alex-semenyuk May 23, 2025
77ffbe6
fix comments
alex-semenyuk May 25, 2025
ae5840f
Address comment
alex-semenyuk Jun 7, 2025
File filter

Filter by extension

Filter by extension .py  (1) All 1 file type selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
22 changes: 22 additions & 0 deletions Lib/test/test_gettext.py
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -937,6 +937,28 @@ def test_lazy_import(self):
ensure_lazy_imports("gettext", {"re", "warnings", "locale"})


class DGettextTest(GettextBaseTest):

def setUp(self):
super().setUp()
gettext.bindtextdomain('gettext', os.curdir)

picnixz Jun 2, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Don't we need to tearDown this one?

alex-semenyuk Jun 7, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Seems reset_gettext() resets the state from GettextBaseTest is enough

def test_dgettext_translation(self):
translation_cases = [
('gettext', 'mullusk', 'bacon'),
('gettext', 'Raymond Luxury Yach-t', 'Throatwobbler Mangrove'),
('gettext', 'nudge nudge', 'wink wink'),

('gettext', 'missing message', 'missing message'),
('nonexistent_domain', 'mullusk', 'mullusk'),
('', 'mullusk', gettext.gettext('mullusk')),
]
for domain, msgid, expected in translation_cases:
with self.subTest(domain=domain, msgid=msgid):
result = gettext.dgettext(domain, msgid)
self.assertEqual(result, expected)


if __name__ == '__main__':
unittest.main()

Expand Down
Back | FazBrowse Home | New Git URL