gh-130655: add tests for dgettext by alex-semenyuk · Pull Request #134594 · python/cpython · GitHub

add tests for dgettext

Issue: Increase test coverage for dgettext #134593

Issue: Increase test coverage of gettext #130655

Avoid using docstrings for test_* methods as it will be shown upon failure.

Instead of using mkdtemp which would create something inside /tmp, use test.support.temp_dir (I think, check the name) which creates something inside the build folder (it's easier to cleanup)

Prefer using os_helper.rmtree over shutil.rmtree

We can inherit from GettextBaseTest and avail of the mo files. You can then use the messages in the files to test it works properly.

We can still simply them a lot, you have to remember dgettext is really just a wrapper.

Let's keep the TODO, since it is still valid (the first part).

It can be updated with the issue number if you wish.

I don't think we need these these anyway, it's long and pretty much identical to the previous two. dgettext is a pretty simple wrapper. Maybe merge the first two test_dgettext_translation for organization

Why not just store the expected, it is clearer. And this part is made simpler.

Join this one with the other two, these all test the exact same thing (which is well tested above too).

Thanks for the PR @alex-semenyuk! Would you mind measuring the test coverage before and after this change and sharing the results here? (after you address the review comments)
Just to make sure we covered everything 🙂 Thanks!

Suggested change

      
                    GettextBaseTest.setUp(self)
          
                    super().setUp()

Don't we need to tearDown this one?

Seems reset_gettext() resets the state from GettextBaseTest is enough

This PR is stale because it has been open for 30 days with no activity.

This PR is stale because it has been open for 90 days with no activity.

This PR is superseded by #154006, a newer open pull request for the same issue (gh-130655), and it no longer merges cleanly. Closing to cull the number of open pull requests. Do not reopen this pull request without getting a go-ahead from a triager or core developer.

pythongh-134593 : add tests for dgettext

16165b5

bedevere-app Bot added the tests Tests in the Lib/test dir label May 23, 2025

bedevere-app Bot mentioned this pull request May 23, 2025

Increase test coverage for dgettext #134593

Closed

bedevere-app Bot added the awaiting review label May 23, 2025

picnixz reviewed May 23, 2025

View reviewed changes

fix comments

c4fb7ac

alex-semenyuk force-pushed the add_dgettext_tests branch from ecaa9d1 to c4fb7ac Compare May 23, 2025 18:51

picnixz added the skip news label May 23, 2025

StanFromIreland reviewed May 23, 2025

View reviewed changes

Comment thread Lib/test/test_gettext.py Outdated

picnixz changed the title gh-134593: add tests for dgettext gh-130655: add tests for dgettext May 23, 2025

bedevere-app Bot mentioned this pull request May 23, 2025

Increase test coverage of gettext #130655

Open

picnixz added needs backport to 3.13 only security fixes needs backport to 3.14 bugs and security fixes labels May 23, 2025

fix comments

77ffbe6

alex-semenyuk force-pushed the add_dgettext_tests branch from 43ffa67 to 77ffbe6 Compare May 25, 2025 10:27

alex-semenyuk requested a review from picnixz May 25, 2025 10:56

StanFromIreland reviewed May 25, 2025

View reviewed changes

picnixz requested review from picnixz and tomasr8 and removed request for picnixz May 25, 2025 22:55

picnixz reviewed Jun 2, 2025

View reviewed changes

alex-semenyuk force-pushed the add_dgettext_tests branch from 8824d95 to c57f95b Compare June 7, 2025 08:58

Address comment

ae5840f

alex-semenyuk force-pushed the add_dgettext_tests branch from c57f95b to ae5840f Compare June 7, 2025 08:59

github-actions Bot added the stale Stale PR or inactive for long period of time. label Apr 25, 2026

StanFromIreland mentioned this pull request Apr 28, 2026

gh-130655: add tests for dgettext, dpgettext, dngettext, and dnpgettext functions #148430

Closed

serhiy-storchaka added the needs backport to 3.15 bugs and security fixes label May 30, 2026

github-actions Bot removed the stale Stale PR or inactive for long period of time. label May 31, 2026

StanFromIreland mentioned this pull request Jul 18, 2026

Add tests for dgettext, dngettext, dpgettext, dnpgettext functions #153887

Closed

magic-peach mentioned this pull request Jul 18, 2026

gh-130655: Add tests for dgettext, dngettext, dpgettext, dnpgettext #154006

Closed

github-actions Bot added the stale Stale PR or inactive for long period of time. label Sep 3, 2026

ambv closed this Oct 20, 2026

+                  def setUp(self):
+                      """Set up a specific test domain and environment for dgettext tests."""
+                      self.localedir = tempfile.mkdtemp()
+                      self.addCleanup(shutil.rmtree, self.localedir)

+                  def test_dgettext_luxury_yacht_translation(self):
+                      result = gettext.dgettext('gettext', 'Raymond Luxury Yach-t')
+                      self.assertEqual(result, 'Throatwobbler Mangrove')
+                  def test_dgettext_nudge_nudge_translation(self):
+                      result = gettext.dgettext('gettext', 'nudge nudge')
+                      self.assertEqual(result, 'wink wink')
+                  def test_dgettext_multiline_translation(self):

+                              if domain == '':
+                                  expected = gettext.gettext(message)
+                              else:
+                                  expected = message

+                      return mofile
+                  def test_dgettext_found_translation(self):
+                      """Test dgettext finds translation in specified domain."""



		# TODO:
		# - Add new tests, for example for "dgettext"

gh-130655: add tests for dgettext by alex-semenyuk · Pull Request #134594 · python/cpython · GitHub

Repository navigation

gh-130655: add tests for dgettext - #134594

gh-130655: add tests for dgettext#134594alex-semenyuk wants to merge 4 commits intopython:mainpython/cpython:mainfrom alex-semenyuk:add_dgettext_testsalex-semenyuk/cpython:add_dgettext_testsCopy head branch name to clipboard

Conversation

alex-semenyuk commented May 23, 2025 • edited by bedevere-app Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

StanFromIreland left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

StanFromIreland left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tomasr8 commented May 26, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Apr 25, 2026

Uh oh!

github-actions Bot commented Sep 3, 2026

Uh oh!

ambv commented Oct 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

gh-130655: add tests for dgettext#134594
alex-semenyuk wants to merge 4 commits into
python:mainfrom
alex-semenyuk:add_dgettext_tests

alex-semenyuk commented May 23, 2025 •
edited by bedevere-app Bot
Loading