Repository navigation
Add tests for dgettext, dngettext, dpgettext, dnpgettext functions - #153887
Closed
magic-peach wants to merge 1 commit into
Closed
magic-peach wants to merge 1 commit into
magic-peach wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Add comprehensive test coverage for the domain-specific gettext functions that were previously untested. This addresses the TODO comment in test_gettext.py that explicitly requested tests for these functions. Changes: - Remove TODO comment requesting dgettext tests - Add DGettextTests class with 7 tests for dgettext() - Add DnGettextTests class with 7 tests for dngettext() - Add DpGettextTests class with 6 tests for dpgettext() - Add DnpGettextTests class with 7 tests for dnpgettext() Each test covers: - Basic translation functionality - Fallback behavior for missing domains - Behavior when translations are missing - Edge cases (wrong context, large numbers, special characters)
Copy link
Copy Markdown
|
The following commit authors need to sign the Contributor License Agreement: |
Sorry, something went wrong.
Copy link
Copy Markdown
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead. |
Sorry, something went wrong.
Copy link
Copy Markdown
Author
|
Closing as this is a duplicate of #134594 (dgettext tests) and #148430 (which covered dgettext, dpgettext, dngettext, and dnpgettext). Thank you for the review feedback from @StanFromIreland. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds comprehensive test coverage for the domain-specific gettext functions (dgettext, dngettext, dpgettext, dnpgettext) that were previously untested. This addresses an explicit TODO comment in test_gettext.py that requested tests for these functions.
Changes
Test Coverage
Each test class covers:
Motivation
The gettext module provides both non-domain-specific functions (gettext, ngettext, pgettext, npgettext) and domain-specific functions (dgettext, dngettext, dpgettext, dnpgettext). While the non-domain functions had test coverage, the domain-specific functions were only tested indirectly through the PluralFormsTests mixin. This PR adds direct, focused tests for each domain-specific function.
The existing TODO comment in the file explicitly requested:
This contribution follows the coding style of the existing tests and uses the same test fixtures (GNU_MO_DATA) that are already defined in the file.