FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-130655: add tests for dgettext, dpgettext, dngettext, and dnpgettext functions by sergiolpzgmz · Pull Request #148430 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-130655: add tests for dgettext, dpgettext, dngettext, and dnpgettext functions - #148430

Closed
sergiolpzgmz wants to merge 4 commits into
python:mainfrom
sergiolpzgmz:add-dgettext-tests
ConversationCommits (4)ChecksFiles changed
Closed

gh-130655: add tests for dgettext, dpgettext, dngettext, and dnpgettext functions#148430
sergiolpzgmz wants to merge 4 commits into
python:mainfrom
sergiolpzgmz:add-dgettext-tests

Conversation

sergiolpzgmz commented Apr 12, 2026 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

Address the TODO in Lib/test/test_gettext.py:13-15

# TODO:
#  - Add new tests, for example for "dgettext"
#  - Tests should have only one assert.

Following the TODO guidance, each test has only one assert.
These functions were not previously tested directly, only indirectly
through other test classes.

sergiolpzgmz requested a review from tomasr8 as a code owner April 12, 2026 09:38

python-cla-bot Bot commented Apr 12, 2026 •
edited
Loading

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.

bedevere-app Bot added awaiting review tests Tests in the Lib/test dir labels Apr 12, 2026

bedevere-app Bot commented Apr 12, 2026

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

picnixz requested a review from StanFromIreland April 12, 2026 11:49
sergiolpzgmz changed the title Add tests for dgettext, dpgettext, dngettext, and dnpgettext functions Tests: add tests for dgettext, dpgettext, dngettext, and dnpgettext functions Apr 13, 2026

StanFromIreland commented Apr 28, 2026

Copy link
Copy Markdown
Member

Note that there is an existing PR for dgettext: #134594

sergiolpzgmz changed the title Tests: add tests for dgettext, dpgettext, dngettext, and dnpgettext functions gh-130655: add tests for dgettext, dpgettext, dngettext, and dnpgettext functions Apr 28, 2026
bedevere-app Bot mentioned this pull request Apr 28, 2026
Open

sergiolpzgmz commented Apr 28, 2026

Copy link
Copy Markdown
Contributor Author

Note that there is an existing PR for dgettext: #134594

Hi @StanFromIreland,

Thanks! I didn't notice PR #134594 during my prior research before starting this development.
My goal was to address the TODOs in the test suite by adding coverage for dgettext and its related functions, following the 'one assert per test' rule.
I would love to receive your feedback if you still consider my contribution valid.

magic-peach mentioned this pull request Jul 18, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

tomasr8 Awaiting requested review from tomasr8 tomasr8 is a code owner
StanFromIreland Awaiting requested review from StanFromIreland

Assignees

No one assigned

Labels

awaiting review skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL