Repository navigation
gh-134531: use EVP_MAC API for _hashlib.HMAC - #135235
picnixz merged 63 commits into
Conversation
Sorry, something went wrong.
|
!buildbot FIPS |
Sorry, something went wrong.
|
🤖 New build scheduled with the buildbot fleet by @picnixz for commit c444180 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F135235%2Fmerge The command will test the builders whose names match following regular expression: FIPS The builders matched are:
|
Sorry, something went wrong.
picnixz
left a comment
There was a problem hiding this comment.
Overall, there is also something I wanted to investigate, namely "is it faster to use SN_* names or LN_* names for OpenSSL" and whether it's better to cache the NID (as it's only used in __repr__ or .name) or directly cache a const char *.
I'll need more experiments for this one but this also applies to the existing code where we work with EVP_MD objects instead of caching their properties.
Sorry, something went wrong.
…shlib/evp-mac-134531
…/evp-mac-134531 # Conflicts: # Modules/_hashopenssl.c
|
I'll split the PR a bit more (some changes can be atomically changed). IOW, I'll first split the changes that I can and then I'll just need to add the OpenSSL 3 path |
Sorry, something went wrong.
…ixz/cpython into feat/hashlib/evp-mac-134531
|
!buildbot FIPS only |
Sorry, something went wrong.
|
🤖 New build scheduled with the buildbot fleet by @picnixz for commit 3559f22 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F135235%2Fmerge The command will test the builders whose names match following regular expression: FIPS only The builders matched are:
|
Sorry, something went wrong.
|
🤖 New build scheduled with the buildbot fleet by @picnixz for commit 36f26a0 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F135235%2Fmerge If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again. |
Sorry, something went wrong.
|
!buildbot FIPS only |
Sorry, something went wrong.
|
🤖 New build scheduled with the buildbot fleet by @picnixz for commit 36f26a0 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F135235%2Fmerge The command will test the builders whose names match following regular expression: FIPS only The builders matched are:
|
Sorry, something went wrong.
Just a draft PR for the CI. I'll split the PR tomorrow. Some parts are part of #135234.
This is based on top of #135250 and #135254 so it's a bit messy.