FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-135234: improve `_hashlib` exceptions when reporting an OpenSSL function failure by picnixz · Pull Request #135250 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-135234: improve _hashlib exceptions when reporting an OpenSSL function failure - #135250

Merged
picnixz merged 19 commits into
python:mainfrom
picnixz:feat/hashlib/smart-exceptions-135234
Jun 9, 2025
ConversationCommits (19)ChecksFiles changed
Merged

gh-135234: improve _hashlib exceptions when reporting an OpenSSL function failure#135250
picnixz merged 19 commits into
python:mainfrom
picnixz:feat/hashlib/smart-exceptions-135234

Conversation

picnixz commented Jun 8, 2025 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

The commits are separated for review purposes but won't compile separately.

picnixz requested a review from gpshead as a code owner June 8, 2025 09:28
bedevere-app Bot mentioned this pull request Jun 8, 2025
Closed
picnixz marked this pull request as draft June 8, 2025 09:45
picnixz marked this pull request as ready for review June 8, 2025 09:54

picnixz commented Jun 8, 2025

Copy link
Copy Markdown
Member Author

!buildbot FIPS

bedevere-bot commented Jun 8, 2025

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @picnixz for commit e226431 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F135250%2Fmerge

The command will test the builders whose names match following regular expression: FIPS

The builders matched are:

  • AMD64 CentOS9 FIPS No Builtin Hashes PR
  • AMD64 RHEL8 FIPS Only Blake2 Builtin Hash PR
  • AMD64 RHEL8 FIPS No Builtin Hashes PR
  • AMD64 CentOS9 FIPS Only Blake2 Builtin Hash PR

picnixz commented Jun 8, 2025 •
edited
Loading

Copy link
Copy Markdown
Member Author

We need a job running the SSL tests with solely OpenSSL 1.1.1, because it appears that sometimes there is no error on 3.0 but there are some on 1.1.1.

picnixz commented Jun 8, 2025

Copy link
Copy Markdown
Member Author

!buildbot FIPS

bedevere-bot commented Jun 8, 2025

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @picnixz for commit 7201e0a 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F135250%2Fmerge

The command will test the builders whose names match following regular expression: FIPS

The builders matched are:

  • AMD64 CentOS9 FIPS No Builtin Hashes PR
  • AMD64 RHEL8 FIPS Only Blake2 Builtin Hash PR
  • AMD64 RHEL8 FIPS No Builtin Hashes PR
  • AMD64 CentOS9 FIPS Only Blake2 Builtin Hash PR

This was referenced Jun 8, 2025
Merged
Merged

picnixz commented Jun 8, 2025

Copy link
Copy Markdown
Member Author

!buildbot FIPS only

bedevere-bot commented Jun 8, 2025

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @picnixz for commit 76c7dd2 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F135250%2Fmerge

The command will test the builders whose names match following regular expression: FIPS only

The builders matched are:

  • AMD64 RHEL8 FIPS Only Blake2 Builtin Hash PR
  • AMD64 CentOS9 FIPS Only Blake2 Builtin Hash PR

gpshead approved these changes Jun 8, 2025
View reviewed changes

gpshead left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

nice!

Comment thread Misc/NEWS.d/next/Library/2025-06-08-11-11-07.gh-issue-135234.wJCdh0.rst
picnixz self-assigned this Jun 8, 2025
picnixz merged commit 83b94e8 into python:main Jun 9, 2025
picnixz deleted the feat/hashlib/smart-exceptions-135234 branch June 9, 2025 07:13
lkollar pushed a commit to lkollar/cpython that referenced this pull request Jun 19, 2025
pythongh-135234: improve _hashlib exceptions when reporting an Open…
05412cb 
…SSL function failure (python#135250)

- Refactor `get_openssl_evp_md_by_utf8name` error branches.
- Refactor `HASH.{digest,hexdigest}` computations.
- Refactor `_hashlib_HASH_copy_locked` and `locked_HMAC_CTX_copy`.
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
pythongh-135234: improve _hashlib exceptions when reporting an Open…
d34d116 
…SSL function failure (python#135250)

- Refactor `get_openssl_evp_md_by_utf8name` error branches.
- Refactor `HASH.{digest,hexdigest}` computations.
- Refactor `_hashlib_HASH_copy_locked` and `locked_HMAC_CTX_copy`.
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
pythongh-135234: improve _hashlib exceptions when reporting an Open…
297bcef 
…SSL function failure (python#135250)

- Refactor `get_openssl_evp_md_by_utf8name` error branches.
- Refactor `HASH.{digest,hexdigest}` computations.
- Refactor `_hashlib_HASH_copy_locked` and `locked_HMAC_CTX_copy`.
Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull request Aug 19, 2025
pythongh-135234: improve _hashlib exceptions when reporting an Open…
f9de525 
…SSL function failure (python#135250)

- Refactor `get_openssl_evp_md_by_utf8name` error branches.
- Refactor `HASH.{digest,hexdigest}` computations.
- Refactor `_hashlib_HASH_copy_locked` and `locked_HMAC_CTX_copy`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

gpshead gpshead approved these changes

Assignees

picnixz

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL