FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

GH-135904: Improve the JIT's performance on macOS by brandtbucher · Pull Request #136528 · python/cpython · GitHub

/ cpython Public

GH-135904: Improve the JIT's performance on macOS - #136528

Merged
brandtbucher merged 8 commits into
python:mainfrom
brandtbucher:jit-targets
Jul 14, 2025
Merged

GH-135904: Improve the JIT's performance on macOS#136528
brandtbucher merged 8 commits into
python:mainfrom
brandtbucher:jit-targets

Conversation

brandtbucher commented Jul 11, 2025
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

This PR makes a couple of minor tweaks to the JIT that result in 1.7% faster performance on macOS overall:

  • Our AArch64 code doesn't need to be 8-byte aligned, just the data. Currently, we guarantee this by aligning all code anyways, since the data follows immediately after it. This is wasteful, since it means about half of all stencils end in a nop. Instead, don't pad any stencils, and just align the data when it's compiled. 🤦🏼
  • The textual assembly "optimizer" pass has a bug where it interprets lines that are commented with ; as instructions. By recognizing these commented lines, we can remove more zero-length jumps at the end of stencils. 🤦🏼
  • During this same pass, we can represent the address of the next instruction (the end of the template, or the _JIT_CONTINUE label) as a "local" label, which allows the assembler to resolve it at compile time and encode it more efficiently. There's a special (platform-dependent) prefix to signal this.
  • Finally, instead of declaring jump targets (_JIT_CONTINUE, _JIT_ERROR_TARGET, and _JIT_JUMP_TARGET) as extern symbols, just declare them as local functions. This results in more efficient jumps (and also allows us to remove a somewhat hacky pre-processing step for the textual assembly on Windows to force these efficient jumps).

brandtbucher requested a review from diegorusso July 11, 2025 02:01
brandtbucher self-assigned this Jul 11, 2025
brandtbucher added performance Performance or resource usage skip news interpreter-core (Objects, Python, Grammar, and Parser dirs) topic-JIT labels Jul 11, 2025

Copy link
Copy Markdown
Member

This is amazing! I can't review it, but thanks for all your assembler wizardry on this.

diegorusso left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks. The PR looks great, thanks for making the JIT so much clearer to reason about.

brandtbucher merged commit 3d8c38f into python:main Jul 14, 2025
62 checks passed
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull request Aug 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

interpreter-core (Objects, Python, Grammar, and Parser dirs) performance Performance or resource usage skip news topic-JIT

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL