JIT: Fix compiler warning from visibility attribute in typedef - #139981
Merged
savannahostrowski merged 7 commits intoNov 3, 2025
Merged
JIT: Fix compiler warning from visibility attribute in typedef#139981savannahostrowski merged 7 commits into
savannahostrowski merged 7 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
savannahostrowski
requested review from
brandtbucher and
diegorusso
as code owners
October 12, 2025 04:11
chris-eibl
approved these changes
Oct 18, 2025
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM. Basically the same as my PR #140286 I've just closed since @Fidget-Spinner made me aware of yours :)
Just a suggestion:
Sorry, something went wrong.
chris-eibl
reviewed
Oct 18, 2025
Comment thread
Tools/jit/trampoline.c
Outdated
Copy link
Copy Markdown
Member
|
Sorry for being such a pain, this is now merely for my understanding and I hope asking this question here is ok: When playing with the above Godbolt link, I more or less get the same nice output for jit_stencils-x86_64-unknown-linux-gnu.h in WSL: void
emit_trampoline(
unsigned char *code, unsigned char *data, _PyExecutorObject *executor,
const _PyUOpInstruction *instruction, jit_state *state)
{
//
// trampoline.o: file format elf64-x86-64
//
// Disassembly of section .text:
//
// 0000000000000000 <_JIT_ENTRY>:
// 0: 41 57 pushq %r15
// 2: 41 56 pushq %r14
// 4: 41 55 pushq %r13
// 6: 41 54 pushq %r12
// 8: 53 pushq %rbx
// 9: 49 89 f4 movq %rsi, %r12
// c: 49 89 d5 movq %rdx, %r13
// f: 49 89 ce movq %rcx, %r14
// 12: ff 57 70 callq *0x70(%rdi)
// 15: 5b popq %rbx
// 16: 41 5c popq %r12
// 18: 41 5d popq %r13
// 1a: 41 5e popq %r14
// 1c: 41 5f popq %r15
// 1e: c3 retq
const unsigned char code_body[31] = {
0x41, 0x57, 0x41, 0x56, 0x41, 0x55, 0x41, 0x54,
0x53, 0x49, 0x89, 0xf4, 0x49, 0x89, 0xd5, 0x49,
0x89, 0xce, 0xff, 0x57, 0x70, 0x5b, 0x41, 0x5c,
0x41, 0x5d, 0x41, 0x5e, 0x41, 0x5f, 0xc3,
};
memcpy(code, code_body, sizeof(code_body));
}
whereas on Windows x86_64 I get void
emit_trampoline(
unsigned char *code, unsigned char *data, _PyExecutorObject *executor,
const _PyUOpInstruction *instruction, jit_state *state)
{
//
// trampoline.o: file format coff-x86-64
//
// Disassembly of section .text:
//
// 0000000000000000 <_JIT_ENTRY>:
// 0: 41 57 pushq %r15
// 2: 41 56 pushq %r14
// 4: 41 55 pushq %r13
// 6: 41 54 pushq %r12
// 8: 56 pushq %rsi
// 9: 57 pushq %rdi
// a: 53 pushq %rbx
// b: 48 81 ec a0 00 00 00 subq $0xa0, %rsp
// 12: 44 0f 29 bc 24 90 00 00 00 movaps %xmm15, 0x90(%rsp)
// 1b: 44 0f 29 b4 24 80 00 00 00 movaps %xmm14, 0x80(%rsp)
// 24: 44 0f 29 6c 24 70 movaps %xmm13, 0x70(%rsp)
// 2a: 44 0f 29 64 24 60 movaps %xmm12, 0x60(%rsp)
// 30: 44 0f 29 5c 24 50 movaps %xmm11, 0x50(%rsp)
// 36: 44 0f 29 54 24 40 movaps %xmm10, 0x40(%rsp)
// 3c: 44 0f 29 4c 24 30 movaps %xmm9, 0x30(%rsp)
// 42: 44 0f 29 44 24 20 movaps %xmm8, 0x20(%rsp)
// 48: 0f 29 7c 24 10 movaps %xmm7, 0x10(%rsp)
// 4d: 0f 29 34 24 movaps %xmm6, (%rsp)
// 51: 49 89 d4 movq %rdx, %r12
// 54: 4d 89 c5 movq %r8, %r13
// 57: 4d 89 ce movq %r9, %r14
// 5a: ff 51 70 callq *0x70(%rcx)
// 5d: 0f 28 34 24 movaps (%rsp), %xmm6
// 61: 0f 28 7c 24 10 movaps 0x10(%rsp), %xmm7
// 66: 44 0f 28 44 24 20 movaps 0x20(%rsp), %xmm8
// 6c: 44 0f 28 4c 24 30 movaps 0x30(%rsp), %xmm9
// 72: 44 0f 28 54 24 40 movaps 0x40(%rsp), %xmm10
// 78: 44 0f 28 5c 24 50 movaps 0x50(%rsp), %xmm11
// 7e: 44 0f 28 64 24 60 movaps 0x60(%rsp), %xmm12
// 84: 44 0f 28 6c 24 70 movaps 0x70(%rsp), %xmm13
// 8a: 44 0f 28 b4 24 80 00 00 00 movaps 0x80(%rsp), %xmm14
// 93: 44 0f 28 bc 24 90 00 00 00 movaps 0x90(%rsp), %xmm15
// 9c: 48 81 c4 a0 00 00 00 addq $0xa0, %rsp
// a3: 5b popq %rbx
// a4: 5f popq %rdi
// a5: 5e popq %rsi
// a6: 41 5c popq %r12
// a8: 41 5d popq %r13
// aa: 41 5e popq %r14
// ac: 41 5f popq %r15
// ae: c3 retq
const unsigned char code_body[175] = {
0x41, 0x57, 0x41, 0x56, 0x41, 0x55, 0x41, 0x54,
0x56, 0x57, 0x53, 0x48, 0x81, 0xec, 0xa0, 0x00,
0x00, 0x00, 0x44, 0x0f, 0x29, 0xbc, 0x24, 0x90,
0x00, 0x00, 0x00, 0x44, 0x0f, 0x29, 0xb4, 0x24,
0x80, 0x00, 0x00, 0x00, 0x44, 0x0f, 0x29, 0x6c,
0x24, 0x70, 0x44, 0x0f, 0x29, 0x64, 0x24, 0x60,
0x44, 0x0f, 0x29, 0x5c, 0x24, 0x50, 0x44, 0x0f,
0x29, 0x54, 0x24, 0x40, 0x44, 0x0f, 0x29, 0x4c,
0x24, 0x30, 0x44, 0x0f, 0x29, 0x44, 0x24, 0x20,
0x0f, 0x29, 0x7c, 0x24, 0x10, 0x0f, 0x29, 0x34,
0x24, 0x49, 0x89, 0xd4, 0x4d, 0x89, 0xc5, 0x4d,
0x89, 0xce, 0xff, 0x51, 0x70, 0x0f, 0x28, 0x34,
0x24, 0x0f, 0x28, 0x7c, 0x24, 0x10, 0x44, 0x0f,
0x28, 0x44, 0x24, 0x20, 0x44, 0x0f, 0x28, 0x4c,
0x24, 0x30, 0x44, 0x0f, 0x28, 0x54, 0x24, 0x40,
0x44, 0x0f, 0x28, 0x5c, 0x24, 0x50, 0x44, 0x0f,
0x28, 0x64, 0x24, 0x60, 0x44, 0x0f, 0x28, 0x6c,
0x24, 0x70, 0x44, 0x0f, 0x28, 0xb4, 0x24, 0x80,
0x00, 0x00, 0x00, 0x44, 0x0f, 0x28, 0xbc, 0x24,
0x90, 0x00, 0x00, 0x00, 0x48, 0x81, 0xc4, 0xa0,
0x00, 0x00, 0x00, 0x5b, 0x5f, 0x5e, 0x41, 0x5c,
0x41, 0x5d, 0x41, 0x5e, 0x41, 0x5f, 0xc3,
};
// 0: '\x00\x00\x00\x00'
// 4: 00 00 00 00
memcpy(code, code_body, sizeof(code_body));
}
which tells me, clang-cl is saving a ton more on the stack here.
|
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Oh, I think I've found the answer myself: adding __attribute__((ms_abi)) to the _JIT_ENTRY function results in similar code as in the stencil, so it is just following MS ABI ... |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Maybe also restore the comment // Note that this is *not* a tail call: that got lost in #137961? Because it is utterly important that we use jit_func_preserve_none here and not jit_func, because this would result in a tail call. |
Sorry, something went wrong.
Fidget-Spinner
approved these changes
Nov 3, 2025
savannahostrowski
enabled auto-merge (squash)
November 3, 2025 19:27
Copy link
Copy Markdown
|
Thanks @savannahostrowski for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14. |
Sorry, something went wrong.
Copy link
Copy Markdown
|
Sorry, @savannahostrowski, I could not cleanly backport this to 3.14 due to a conflict. cherry_picker 57f4d09a6fcfec229603f644c4254abdded00429 3.14 |
Sorry, something went wrong.
Copy link
Copy Markdown
⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️Hi! The buildbot ARM64 macOS 3.x (tier-2) has failed when building commit 57f4d09. What do you need to do:
You can take a look at the buildbot page here: https://buildbot.python.org/#/builders/725/builds/12253 Summary of the results of the build (if available): == Click to see traceback logsTraceback (most recent call last):
File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/test/test_urllib2net.py", line 22, in _retry_thrice
last_exc = e
^^^^^^^^
ResourceWarning: unclosed <socket.socket fd=7, family=2, type=1, proto=6, laddr=('192.168.0.101', 61508), raddr=('68.183.26.59', 21)>
Warning -- Unraisable exception
Exception ignored while finalizing socket <socket.socket fd=8, family=2, type=1, proto=6, laddr=('192.168.0.101', 61510), raddr=('68.183.26.59', 21)>:
Traceback (most recent call last):
File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/urllib/request.py", line 1546, in ftp_open
fp, retrlen = fw.retrfile(file, type)
~~~~~~~~~~~^^^^^^^^^^^^
File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/urllib/request.py", line 1826, in retrfile
conn, retrlen = self.ftp.ntransfercmd(cmd)
~~~~~~~~~~~~~~~~~~~~~^^^^^
File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/ftplib.py", line 354, in ntransfercmd
conn = socket.create_connection((host, port), self.timeout,
source_address=self.source_address)
File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/socket.py", line 879, in create_connection
raise exceptions[0]
File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/socket.py", line 864, in create_connection
sock.connect(sa)
~~~~~~~~~~~~^^^^
TimeoutError: [Errno 60] Operation timed out
Traceback (most recent call last):
File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/test/test_urllib2net.py", line 22, in _retry_thrice
last_exc = e
^^^^^^^^
ResourceWarning: unclosed <socket.socket fd=8, family=2, type=1, proto=6, laddr=('192.168.0.101', 61510), raddr=('68.183.26.59', 21)>
skipped "Resource 'ftp://www.pythontest.net/' is not available"
Traceback (most recent call last):
File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/test/test_urllib2net.py", line 22, in _retry_thrice
last_exc = e
^^^^^^^^
ResourceWarning: unclosed <socket.socket fd=11, family=2, type=1, proto=6, laddr=('192.168.0.101', 61529), raddr=('68.183.26.59', 21)>
skipped "Resource 'ftp://www.pythontest.net/' is not available"
Traceback (most recent call last):
File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/test/support/__init__.py", line 847, in gc_collect
gc.collect()
~~~~~~~~~~^^
ResourceWarning: unclosed <socket.socket fd=7, family=2, type=1, proto=6, laddr=('192.168.0.101', 57105), raddr=('68.183.26.59', 21)>
Traceback (most recent call last):
File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/test/test_urllib2net.py", line 22, in _retry_thrice
last_exc = e
^^^^^^^^
ResourceWarning: unclosed <socket.socket fd=9, family=2, type=1, proto=6, laddr=('192.168.0.101', 61520), raddr=('68.183.26.59', 21)>
Warning -- Unraisable exception
Exception ignored while finalizing socket <socket.socket fd=10, family=2, type=1, proto=6, laddr=('192.168.0.101', 61523), raddr=('68.183.26.59', 21)>:
Traceback (most recent call last):
File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/urllib/request.py", line 1546, in ftp_open
fp, retrlen = fw.retrfile(file, type)
~~~~~~~~~~~^^^^^^^^^^^^
File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/urllib/request.py", line 1826, in retrfile
conn, retrlen = self.ftp.ntransfercmd(cmd)
~~~~~~~~~~~~~~~~~~~~~^^^^^
File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/ftplib.py", line 354, in ntransfercmd
conn = socket.create_connection((host, port), self.timeout,
source_address=self.source_address)
File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/socket.py", line 879, in create_connection
raise exceptions[0]
File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/socket.py", line 864, in create_connection
sock.connect(sa)
~~~~~~~~~~~~^^^^
TimeoutError: [Errno 60] Operation timed out
Traceback (most recent call last):
File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/test/test_urllib2net.py", line 22, in _retry_thrice
last_exc = e
^^^^^^^^
ResourceWarning: unclosed <socket.socket fd=6, family=2, type=1, proto=6, laddr=('192.168.0.101', 56902), raddr=('68.183.26.59', 21)>
k
Traceback (most recent call last):
File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/test/support/__init__.py", line 847, in gc_collect
gc.collect()
~~~~~~~~~~^^
ResourceWarning: unclosed <socket.socket fd=7, family=2, type=1, proto=6, laddr=('192.168.0.101', 61512), raddr=('68.183.26.59', 21)>
Warning -- Unraisable exception
Exception ignored while finalizing socket <socket.socket fd=8, family=2, type=1, proto=6, laddr=('192.168.0.101', 61518), raddr=('68.183.26.59', 21)>:
Traceback (most recent call last):
File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/test/support/__init__.py", line 847, in gc_collect
gc.collect()
~~~~~~~~~~^^
ResourceWarning: unclosed <socket.socket fd=8, family=2, type=1, proto=6, laddr=('192.168.0.101', 61518), raddr=('68.183.26.59', 21)>
Warning -- Unraisable exception
Exception ignored while finalizing socket <socket.socket fd=9, family=2, type=1, proto=6, laddr=('192.168.0.101', 61525), raddr=('68.183.26.59', 21)>:
Traceback (most recent call last):
File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/test/support/__init__.py", line 847, in gc_collect
gc.collect()
~~~~~~~~~~^^
ResourceWarning: unclosed <socket.socket fd=9, family=2, type=1, proto=6, laddr=('192.168.0.101', 61525), raddr=('68.183.26.59', 21)>
Warning -- Unraisable exception
Exception ignored while finalizing socket <socket.socket fd=10, family=2, type=1, proto=6, laddr=('192.168.0.101', 61531), raddr=('68.183.26.59', 21)>:
Traceback (most recent call last):
File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/test/support/__init__.py", line 847, in gc_collect
gc.collect()
~~~~~~~~~~^^
ResourceWarning: unclosed <socket.socket fd=10, family=2, type=1, proto=6, laddr=('192.168.0.101', 61531), raddr=('68.183.26.59', 21)>
Traceback (most recent call last):
File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/urllib/request.py", line 1546, in ftp_open
fp, retrlen = fw.retrfile(file, type)
~~~~~~~~~~~^^^^^^^^^^^^
File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/urllib/request.py", line 1826, in retrfile
conn, retrlen = self.ftp.ntransfercmd(cmd)
~~~~~~~~~~~~~~~~~~~~~^^^^^
File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/ftplib.py", line 354, in ntransfercmd
conn = socket.create_connection((host, port), self.timeout,
source_address=self.source_address)
File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/socket.py", line 879, in create_connection
raise exceptions[0]
File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/socket.py", line 864, in create_connection
sock.connect(sa)
~~~~~~~~~~~~^^^^
TimeoutError: [Errno 60] Operation timed out
Traceback (most recent call last):
File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/test/test_urllib2net.py", line 22, in _retry_thrice
last_exc = e
^^^^^^^^
ResourceWarning: unclosed <socket.socket fd=10, family=2, type=1, proto=6, laddr=('192.168.0.101', 61527), raddr=('68.183.26.59', 21)>
Warning -- Unraisable exception
Exception ignored while finalizing socket <socket.socket fd=11, family=2, type=1, proto=6, laddr=('192.168.0.101', 61529), raddr=('68.183.26.59', 21)>:
Traceback (most recent call last):
File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/urllib/request.py", line 1546, in ftp_open
fp, retrlen = fw.retrfile(file, type)
~~~~~~~~~~~^^^^^^^^^^^^
File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/urllib/request.py", line 1826, in retrfile
conn, retrlen = self.ftp.ntransfercmd(cmd)
~~~~~~~~~~~~~~~~~~~~~^^^^^
File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/ftplib.py", line 354, in ntransfercmd
conn = socket.create_connection((host, port), self.timeout,
source_address=self.source_address)
File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/socket.py", line 879, in create_connection
raise exceptions[0]
File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/socket.py", line 864, in create_connection
sock.connect(sa)
~~~~~~~~~~~~^^^^
TimeoutError: [Errno 60] Operation timed out
Traceback (most recent call last):
File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/test/test_urllib2net.py", line 22, in _retry_thrice
last_exc = e
^^^^^^^^
ResourceWarning: unclosed <socket.socket fd=10, family=2, type=1, proto=6, laddr=('192.168.0.101', 61523), raddr=('68.183.26.59', 21)>
skipped "Resource 'ftp://www.pythontest.net/' is not available"
Traceback (most recent call last):
File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/test/test_urllib2net.py", line 20, in _retry_thrice
return func(*args, **kwargs)
File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/urllib/request.py", line 187, in urlopen
return opener.open(url, data, timeout)
~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^
File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/urllib/request.py", line 487, in open
response = self._open(req, data)
File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/urllib/request.py", line 504, in _open
result = self._call_chain(self.handle_open, protocol, protocol +
'_open', req)
File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/urllib/request.py", line 464, in _call_chain
result = func(*args)
File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/urllib/request.py", line 1556, in ftp_open
raise URLError(f"ftp error: {exp}") from exp
urllib.error.URLError: <urlopen error ftp error: [Errno 60] Operation timed out>
Traceback (most recent call last):
File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/test/test_urllib2net.py", line 22, in _retry_thrice
last_exc = e
^^^^^^^^
ResourceWarning: unclosed <socket.socket fd=8, family=2, type=1, proto=6, laddr=('192.168.0.101', 61514), raddr=('68.183.26.59', 21)>
Warning -- Unraisable exception
Exception ignored while finalizing socket <socket.socket fd=9, family=2, type=1, proto=6, laddr=('192.168.0.101', 61516), raddr=('68.183.26.59', 21)>:
Traceback (most recent call last):
File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/urllib/request.py", line 1546, in ftp_open
fp, retrlen = fw.retrfile(file, type)
~~~~~~~~~~~^^^^^^^^^^^^
File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/urllib/request.py", line 1826, in retrfile
conn, retrlen = self.ftp.ntransfercmd(cmd)
~~~~~~~~~~~~~~~~~~~~~^^^^^
File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/ftplib.py", line 354, in ntransfercmd
conn = socket.create_connection((host, port), self.timeout,
source_address=self.source_address)
File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/socket.py", line 879, in create_connection
raise exceptions[0]
File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/socket.py", line 864, in create_connection
sock.connect(sa)
~~~~~~~~~~~~^^^^
TimeoutError: [Errno 60] Operation timed out
Traceback (most recent call last):
File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/test/test_urllib2net.py", line 22, in _retry_thrice
last_exc = e
^^^^^^^^
ResourceWarning: unclosed <socket.socket fd=9, family=2, type=1, proto=6, laddr=('192.168.0.101', 61516), raddr=('68.183.26.59', 21)>
skipped "Resource 'ftp://www.pythontest.net/' is not available"
|
Sorry, something went wrong.
savannahostrowski
added a commit
to savannahostrowski/cpython
that referenced
this pull request
Nov 3, 2025
Copy link
Copy Markdown
Member
Author
|
1 - On second thought, I don't think this should be backported as trampoline.c was added in a8d9d94, which first appeared in 3.15.0a1. 2 - The buildbot failure is unrelated. |
Sorry, something went wrong.
StanFromIreland
pushed a commit
to StanFromIreland/cpython
that referenced
this pull request
Dec 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Assignees
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/Users/runner/work/cpython/cpython/Tools/jit/trampoline.c:13:13: warning: 'visibility' attribute ignored [-Wignored-attributes] 13 | typedef DECLARE_TARGET((*jit_func)); | ^ /Users/runner/work/cpython/cpython/Tools/jit/jit.h:11:49: note: expanded from macro 'DECLARE_TARGET' 11 | _Py_CODEUNIT *__attribute__((preserve_none, visibility("hidden"))) \ |This was introduced in #136528. The DECLARE_TARGET macro includes visibility("hidden"), which is valid for forward declarations but gets ignored when used in a typedef, so the compiler is yelling.