FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-136547: allow to temporarily disable hash algorithms in tests by picnixz · Pull Request #136570 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-136547: allow to temporarily disable hash algorithms in tests - #136570

Merged
picnixz merged 4 commits into
python:mainfrom
picnixz:feat/test/hashlib-disable-136547
Jul 13, 2025
ConversationCommits (4)ChecksFiles changed
Merged

gh-136547: allow to temporarily disable hash algorithms in tests#136570
picnixz merged 4 commits into
python:mainfrom
picnixz:feat/test/hashlib-disable-136547

Conversation

picnixz commented Jul 12, 2025 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

picnixz requested review from gpshead and tiran as code owners July 12, 2025 10:58
bedevere-app Bot mentioned this pull request Jul 12, 2025
Closed
picnixz force-pushed the feat/test/hashlib-disable-136547 branch from 7788d60 to 19792cb Compare July 12, 2025 11:11

picnixz commented Jul 12, 2025

Copy link
Copy Markdown
Member Author

!buildbot FIPS only

bedevere-bot commented Jul 12, 2025

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @picnixz for commit 4c36842 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F136570%2Fmerge

The command will test the builders whose names match following regular expression: FIPS only

The builders matched are:

  • AMD64 RHEL8 FIPS Only Blake2 Builtin Hash PR
  • AMD64 CentOS9 FIPS Only Blake2 Builtin Hash PR

picnixz marked this pull request as draft July 12, 2025 13:53

picnixz commented Jul 12, 2025

Copy link
Copy Markdown
Member Author

!buildbot FIPS

bedevere-bot commented Jul 12, 2025

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @picnixz for commit 879cc73 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F136570%2Fmerge

The command will test the builders whose names match following regular expression: FIPS

The builders matched are:

  • AMD64 CentOS9 FIPS Only Blake2 Builtin Hash PR
  • AMD64 RHEL8 FIPS Only Blake2 Builtin Hash PR
  • AMD64 CentOS9 FIPS No Builtin Hashes PR
  • AMD64 RHEL8 FIPS No Builtin Hashes PR

picnixz self-assigned this Jul 12, 2025
picnixz marked this pull request as ready for review July 12, 2025 19:46
picnixz merged commit 9e5cebd into python:main Jul 13, 2025
picnixz deleted the feat/test/hashlib-disable-136547 branch July 13, 2025 08:58
picnixz added a commit to picnixz/cpython that referenced this pull request Jul 13, 2025
pythongh-136547: allow to temporarily disable hash algorithms in tests (
6475357 
python#136570)
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
pythongh-136547: allow to temporarily disable hash algorithms in tests (
864b5ff 
python#136570)
Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull request Aug 19, 2025
pythongh-136547: allow to temporarily disable hash algorithms in tests (
70ce39e 
python#136570)
picnixz added needs backport to 3.13 only security fixes needs backport to 3.14 bugs and security fixes labels Aug 22, 2025

miss-islington-app Bot commented Aug 22, 2025

Copy link
Copy Markdown

Thanks @picnixz for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington-app Bot commented Aug 22, 2025

Copy link
Copy Markdown

Thanks @picnixz for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 22, 2025
pythongh-136547: allow to temporarily disable hash algorithms in tests (
aedc371 
pythonGH-136570)

(cherry picked from commit 9e5cebd)

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>

miss-islington-app Bot commented Aug 22, 2025

Copy link
Copy Markdown

Sorry, @picnixz, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 9e5cebd56d06e35faeca166813215d72f2f8906a 3.13

bedevere-app Bot commented Aug 22, 2025

Copy link
Copy Markdown

GH-138052 is a backport of this pull request to the 3.14 branch.

bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Aug 22, 2025

picnixz commented Aug 22, 2025

Copy link
Copy Markdown
Member Author

I need to backport this PR and its fix for tests.

picnixz added a commit to picnixz/cpython that referenced this pull request Aug 22, 2025
[3.13] pythongh-136547: allow to temporarily disable hash algorithms …
6f5a82f 
…in tests (pythonGH-136570)

(cherry picked from commit 9e5cebd)

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
picnixz mentioned this pull request Aug 22, 2025
Closed

StanFromIreland commented Nov 5, 2025

Copy link
Copy Markdown
Member

Little reminder about backporting.

StanFromIreland commented Nov 5, 2025

Copy link
Copy Markdown
Member

Ah, I just saw #138053. I will remove the label.

StanFromIreland removed the needs backport to 3.13 only security fixes label Nov 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

gpshead gpshead approved these changes
tiran Awaiting requested review from tiran

Assignees

picnixz

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL