Repository navigation
[3.13] gh-136547: allow to temporarily disable hash algorithms in tests (GH-136570, GH-136762) - #138053
Closed
picnixz wants to merge 3 commits into
Closed
[3.13] gh-136547: allow to temporarily disable hash algorithms in tests (GH-136570, GH-136762)#138053picnixz wants to merge 3 commits into
picnixz wants to merge 3 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
…in tests (pythonGH-136570) (cherry picked from commit 9e5cebd) Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
…ests (python#136762) - Fix `hashlib_helper.block_algorithm` where the dummy functions were incorrectly defined. - Rename `hashlib_helper.HashAPI` to `hashlib_helper.HashInfo` and add more helper methods. - Simplify `hashlib_helper.requires_*()` functions. - Rewrite some private helpers in `hashlib_helper`. - Remove `find_{builtin,openssl}_hashdigest_constructor()` as they are no more needed and were not meant to be public in the first place. - Fix some tests in `test_hashlib` when FIPS mode is on.
Copy link
Copy Markdown
Member
Author
|
Ok, I managed to actually live without those helpers. In the future, if I need to backport tests, I'll reconsider this PR but there would be too many things to change. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This one backports #136570 (9e5cebd) and #136762 (c504f62). However, since HACL* HMAC is only present in 3.14, there are a few helpers that were not needed.