Repository navigation
gh-136547: refactor hashlib_helper for blocking and requesting digests - #136762
Merged
picnixz merged 13 commits intoJul 20, 2025
Merged
picnixz merged 13 commits into
picnixz merged 13 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
picnixz
commented
Jul 18, 2025
Comment thread
Lib/test/support/hashlib_helper.py
Outdated
picnixz
commented
Jul 19, 2025
Comment thread
Lib/test/support/hashlib_helper.py
Outdated
picnixz
marked this pull request as draft
July 19, 2025 17:49
picnixz
commented
Jul 19, 2025
Comment thread
Lib/test/support/hashlib_helper.py
Comment thread
Lib/test/support/hashlib_helper.py
Outdated
Comment thread
Lib/test/support/hashlib_helper.py
Outdated
Comment thread
Lib/test/support/hashlib_helper.py
Outdated
Comment thread
Lib/test/support/hashlib_helper.py
Outdated
picnixz
marked this pull request as ready for review
July 20, 2025 09:41
Copy link
Copy Markdown
Member
Author
|
Urgh, so in my previous PR, I had some bad copy pastes in the wrappers. Fortunately, they were never used until now but my bad. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
!buildbot FIPS only |
Sorry, something went wrong.
Copy link
Copy Markdown
|
🤖 New build scheduled with the buildbot fleet by @picnixz for commit 2b8d5f0 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F136762%2Fmerge The command will test the builders whose names match following regular expression: FIPS only The builders matched are:
|
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
!buildbot FIPS only |
Sorry, something went wrong.
Copy link
Copy Markdown
|
🤖 New build scheduled with the buildbot fleet by @picnixz for commit f4bf516 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F136762%2Fmerge The command will test the builders whose names match following regular expression: FIPS only The builders matched are:
|
Sorry, something went wrong.
picnixz
added a commit
to picnixz/cpython
that referenced
this pull request
Jul 20, 2025
…ests (python#136762) - Fix `hashlib_helper.block_algorithm` where the dummy functions were incorrectly defined. - Rename `hashlib_helper.HashAPI` to `hashlib_helper.HashInfo` and add more helper methods. - Simplify `hashlib_helper.requires_*()` functions. - Rewrite some private helpers in `hashlib_helper`. - Remove `find_{builtin,openssl}_hashdigest_constructor()` as they are no more needed and were not meant to be public in the first place. - Fix some tests in `test_hashlib` when FIPS mode is on.
taegyunkim
pushed a commit
to taegyunkim/cpython
that referenced
this pull request
Aug 4, 2025
…ests (python#136762) - Fix `hashlib_helper.block_algorithm` where the dummy functions were incorrectly defined. - Rename `hashlib_helper.HashAPI` to `hashlib_helper.HashInfo` and add more helper methods. - Simplify `hashlib_helper.requires_*()` functions. - Rewrite some private helpers in `hashlib_helper`. - Remove `find_{builtin,openssl}_hashdigest_constructor()` as they are no more needed and were not meant to be public in the first place. - Fix some tests in `test_hashlib` when FIPS mode is on.
Agent-Hellboy
pushed a commit
to Agent-Hellboy/cpython
that referenced
this pull request
Aug 19, 2025
…ests (python#136762) - Fix `hashlib_helper.block_algorithm` where the dummy functions were incorrectly defined. - Rename `hashlib_helper.HashAPI` to `hashlib_helper.HashInfo` and add more helper methods. - Simplify `hashlib_helper.requires_*()` functions. - Rewrite some private helpers in `hashlib_helper`. - Remove `find_{builtin,openssl}_hashdigest_constructor()` as they are no more needed and were not meant to be public in the first place. - Fix some tests in `test_hashlib` when FIPS mode is on.
picnixz
added a commit
to miss-islington/cpython
that referenced
this pull request
Aug 22, 2025
…ests (python#136762) - Fix `hashlib_helper.block_algorithm` where the dummy functions were incorrectly defined. - Rename `hashlib_helper.HashAPI` to `hashlib_helper.HashInfo` and add more helper methods. - Simplify `hashlib_helper.requires_*()` functions. - Rewrite some private helpers in `hashlib_helper`. - Remove `find_{builtin,openssl}_hashdigest_constructor()` as they are no more needed and were not meant to be public in the first place. - Fix some tests in `test_hashlib` when FIPS mode is on.
picnixz
added a commit
to picnixz/cpython
that referenced
this pull request
Aug 22, 2025
…ests (python#136762) - Fix `hashlib_helper.block_algorithm` where the dummy functions were incorrectly defined. - Rename `hashlib_helper.HashAPI` to `hashlib_helper.HashInfo` and add more helper methods. - Simplify `hashlib_helper.requires_*()` functions. - Rewrite some private helpers in `hashlib_helper`. - Remove `find_{builtin,openssl}_hashdigest_constructor()` as they are no more needed and were not meant to be public in the first place. - Fix some tests in `test_hashlib` when FIPS mode is on.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I made some mistakes in my previous PR and the design I introduced for requesting hashes could actually be greatly simplified. As those two are tightly coupled, I've decided to do both the fix & refactoring at the same time.
Because of all build possibilities we can have, whether at runtime or not, and because some functions can't be given usedforsecurity, tests easily fail because of the underlying configurations. Default builds where we don't have some FIPS module are easy to test, but when FIPS mode is enabled, it's hard to know what is blocked and what is not.
One really annoying thing is the treatment of BLAKE-2 which always falls back to the built-in implementations. Thus, blocking BLAKE-2 may be quite hard and quite different. Well, if we block BLAKE-2 and we don't have OpenSSL at all, then tests don't pass because hashlib.py can't even be imported. Anywsay, I'm opening a draft for now and I'll continue working on this tomorrow.