gh-127146: Emscripten: Fix test_open_undecodable_uri by setting -sTEXTDECODER=2 - #136624
Merged
freakboy3742 merged 1 commit intoJul 13, 2025
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
…DER=2` This removes the JS text decoder fallback and gets rid of the bugs due to the differences in behavior on invalid utf8 strings. See emscripten-core/emscripten#24690.
Copy link
Copy Markdown
Contributor
Author
|
!buildbot emscripten |
Sorry, something went wrong.
Copy link
Copy Markdown
|
🤖 New build scheduled with the buildbot fleet by @hoodmane for commit 358e0a3 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F136624%2Fmerge The command will test the builders whose names match following regular expression: emscripten The builders matched are:
|
Sorry, something went wrong.
freakboy3742
approved these changes
Jul 13, 2025
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Looks like it resolves the test failures in CI, so I'll call that a win
(EDIT: There are still other failures, but this patch results in less failures, and specifically no failure with the sqlite3 tests.)
Sorry, something went wrong.
Copy link
Copy Markdown
|
Thanks @hoodmane for the PR, and @freakboy3742 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14. |
Sorry, something went wrong.
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 13, 2025
… `-sTEXTDECODER=2` (pythonGH-136624) Removes the JS text decoder fallback and gets rid of the bugs due to the differences in behavior on invalid utf8 strings. See emscripten-core/emscripten#24690. (cherry picked from commit 283b050) Co-authored-by: Hood Chatham <roberthoodchatham@gmail.com>
Copy link
Copy Markdown
|
GH-136631 is a backport of this pull request to the 3.14 branch. |
Sorry, something went wrong.
freakboy3742
pushed a commit
that referenced
this pull request
Jul 14, 2025
…g `-sTEXTDECODER=2` (GH-136624) (#136631) Removes the JS text decoder fallback and gets rid of the bugs due to the differences in behavior on invalid utf8 strings. See emscripten-core/emscripten#24690. (cherry picked from commit 283b050) Co-authored-by: Hood Chatham <roberthoodchatham@gmail.com>
hoodmane
added a commit
to hoodmane/cpython
that referenced
this pull request
Jul 16, 2025
…nymore This might have been fixed by pythongh-136624, or by some Emscripten change. In any case, it no longer seems to be needed.
hoodmane
added a commit
to hoodmane/pyodide
that referenced
this pull request
Jul 16, 2025
This makes the code smaller and gets rid of a buggy code path. We switched to this upstream to fix a test: see python/cpython#136624.
freakboy3742
pushed a commit
that referenced
this pull request
Jul 16, 2025
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 16, 2025
…nymore (pythonGH-136707) This might have been fixed by pythongh-136624, or by some Emscripten change. In any case, it no longer seems to be needed. (cherry picked from commit dcd27aa) Co-authored-by: Hood Chatham <roberthoodchatham@gmail.com>
taegyunkim
pushed a commit
to taegyunkim/cpython
that referenced
this pull request
Aug 4, 2025
… `-sTEXTDECODER=2` (python#136624) Removes the JS text decoder fallback and gets rid of the bugs due to the differences in behavior on invalid utf8 strings. See emscripten-core/emscripten#24690.
taegyunkim
pushed a commit
to taegyunkim/cpython
that referenced
this pull request
Aug 4, 2025
…nymore (python#136707) This might have been fixed by pythongh-136624, or by some Emscripten change. In any case, it no longer seems to be needed.
Agent-Hellboy
pushed a commit
to Agent-Hellboy/cpython
that referenced
this pull request
Aug 19, 2025
… `-sTEXTDECODER=2` (python#136624) Removes the JS text decoder fallback and gets rid of the bugs due to the differences in behavior on invalid utf8 strings. See emscripten-core/emscripten#24690.
Agent-Hellboy
pushed a commit
to Agent-Hellboy/cpython
that referenced
this pull request
Aug 19, 2025
…nymore (python#136707) This might have been fixed by pythongh-136624, or by some Emscripten change. In any case, it no longer seems to be needed.
kumaraditya303
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 9, 2025
…setting `-sTEXTDECODER=2` (pythonGH-136624) (python#136631) Removes the JS text decoder fallback and gets rid of the bugs due to the differences in behavior on invalid utf8 strings. See emscripten-core/emscripten#24690. (cherry picked from commit 283b050) Co-authored-by: Hood Chatham <roberthoodchatham@gmail.com>
kumaraditya303
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 9, 2025
…ogate anymore (pythonGH-136707) (python#136717) This might have been fixed by pythongh-136624, or by some Emscripten change. In any case, it no longer seems to be needed. (cherry picked from commit dcd27aa) Co-authored-by: Hood Chatham <roberthoodchatham@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the JS text decoder fallback and gets rid of the bugs due to the differences in behavior on invalid utf8 strings. See emscripten-core/emscripten#24690.