[3.14] gh-127146: Emscripten: Fix test_open_undecodable_uri by setting -sTEXTDECODER=2 (GH-136624) - #136631
Merged
freakboy3742 merged 1 commit intoJul 14, 2025
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
… `-sTEXTDECODER=2` (pythonGH-136624) Removes the JS text decoder fallback and gets rid of the bugs due to the differences in behavior on invalid utf8 strings. See emscripten-core/emscripten#24690. (cherry picked from commit 283b050) Co-authored-by: Hood Chatham <roberthoodchatham@gmail.com>
This was referenced Jul 13, 2025
Copy link
Copy Markdown
Contributor
|
!buildbot emscripten |
Sorry, something went wrong.
Copy link
Copy Markdown
|
🤖 New build scheduled with the buildbot fleet by @freakboy3742 for commit e660f71 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F136631%2Fmerge The command will test the builders whose names match following regular expression: emscripten The builders matched are:
|
Sorry, something went wrong.
freakboy3742
approved these changes
Jul 14, 2025
kumaraditya303
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 9, 2025
…setting `-sTEXTDECODER=2` (pythonGH-136624) (python#136631) Removes the JS text decoder fallback and gets rid of the bugs due to the differences in behavior on invalid utf8 strings. See emscripten-core/emscripten#24690. (cherry picked from commit 283b050) Co-authored-by: Hood Chatham <roberthoodchatham@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the JS text decoder fallback and gets rid of the bugs due to the differences
in behavior on invalid utf8 strings. See emscripten-core/emscripten#24690.
(cherry picked from commit 283b050)
Co-authored-by: Hood Chatham roberthoodchatham@gmail.com