FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-92936: update `http.cookies` docs post GH-113663 by nburns · Pull Request #137566 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-92936: update http.cookies docs post GH-113663 - #137566

Merged
orsenthil merged 9 commits into
python:mainfrom
nburns:update-http-cookie-docs-example
Aug 15, 2025
ConversationCommits (9)ChecksFiles changed
Merged

gh-92936: update http.cookies docs post GH-113663#137566
orsenthil merged 9 commits into
python:mainfrom
nburns:update-http-cookie-docs-example

Conversation

nburns commented Aug 8, 2025 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Contributor

bedevere-app Bot added awaiting review docs Documentation in the Doc dir skip news labels Aug 8, 2025
github-project-automation Bot moved this to Todo in Docs PRs Aug 8, 2025
bedevere-app Bot mentioned this pull request Aug 8, 2025
Closed
picnixz reviewed Aug 8, 2025
View reviewed changes

picnixz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Also add a What's New entry (Doc/whatsnew/3.15.rst).

Comment thread Doc/library/http.cookies.rst Outdated
picnixz changed the title gh-92936: update http.cookie docs gh-92936: update http.cookies docs post GH-113663 Aug 8, 2025
nburns requested a review from AA-Turner as a code owner August 8, 2025 20:35
nburns mentioned this pull request Aug 8, 2025
Merged
nburns force-pushed the update-http-cookie-docs-example branch from 1416a5f to 8598956 Compare August 8, 2025 20:37
picnixz reviewed Aug 8, 2025
View reviewed changes
Comment thread Doc/whatsnew/3.15.rst Outdated
Comment thread Doc/whatsnew/3.15.rst Outdated
Comment thread Doc/whatsnew/3.15.rst Outdated
nburns force-pushed the update-http-cookie-docs-example branch from 8598956 to 75803bc Compare August 8, 2025 20:57

picnixz commented Aug 8, 2025

Copy link
Copy Markdown
Member

Please avoid force-pushing. It makes incremental review harder. We squash-merge commits at the end.

nburns and others added 3 commits August 8, 2025 14:27
Update Doc/library/http.cookies.rst
b92bdf7 
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
Update Doc/whatsnew/3.15.rst
7ec1391 
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
spelling, quote
78d0d1b

nburns commented Aug 8, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

I sure will, thanks for all your help!

picnixz reviewed Aug 8, 2025
View reviewed changes
Comment thread Doc/library/http.cookies.rst
nburns requested a review from orsenthil August 12, 2025 21:02
orsenthil reviewed Aug 13, 2025
View reviewed changes
Comment thread Doc/library/http.cookies.rst Outdated
Update Doc/library/http.cookies.rst
d71b806 
Co-authored-by: Senthil Kumaran <senthil@python.org>
orsenthil approved these changes Aug 13, 2025
View reviewed changes

orsenthil left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

AA-Turner reviewed Aug 14, 2025
View reviewed changes
Comment thread Doc/library/http.cookies.rst Outdated
Comment thread Doc/library/http.cookies.rst Outdated
Comment thread Doc/whatsnew/3.15.rst Outdated
Comment on lines +269 to +270
* Allow ``"`` double quotes in cookie values with a more linient regex for
double-quoted strings.

AA-Turner Aug 14, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Can we be more specific about what's changed than "a more lenient regex"? For example, do we now properly conform to an RFC/web specification? Are there restrictions that still exist on double-quoted strings?

Suggested change
* Allow ``"`` double quotes in cookie values with a more linient regex for
double-quoted strings.
* Allow '``"``' double quotes in cookie values with a more lenient regex for
double-quoted strings.

Apply suggestions from code review
ccc42e5 
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
nburns commented Aug 14, 2025
View reviewed changes
Comment thread Doc/whatsnew/3.15.rst Outdated
Comment on lines +269 to +270
* Allow '``"``' double quotes in cookie values with a more lenient regex for
double-quoted strings.

nburns Aug 14, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality
Suggested change
* Allow '``"``' double quotes in cookie values with a more lenient regex for
double-quoted strings.
* Allow '``"``' double quotes in cookie values with a more lenient regex for
double-quoted strings by not explicitly excluding a quote inside the value part of a cookie.

It's pretty similar to what was there before, just doesn't exclude the quotes: https://github.com/python/cpython/pull/113663/files#diff-e49aab1421911b035542d1a9221c31b8c74053f0e8b28f90f03af66177026176R429

orsenthil Aug 15, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This is becoming little too detailed for a whatsnew item. Since it is both a bugfix and behavior change (ref #137566 (comment))

We could say - "Allow '"' double quotes in cookie values" or the existing detail is fine with me.

@AA-Turner, what is your suggestion here?

nburns Aug 15, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Personally I'm a fan of the shorter

"Allow '"' double quotes in cookie values"

orsenthil Aug 15, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I am good with the shorter version too. It is clear without confusing on the internal details like lenient regex (which the reader of whatsnew doc doesn't need to bother about) and if they really want they could refer to git log, bug report and other discussions.

orsenthil commented Aug 15, 2025

Copy link
Copy Markdown
Member

LGTM.

orsenthil merged commit d86c225 into python:main Aug 15, 2025
github-project-automation Bot moved this from Todo to Done in Docs PRs Aug 15, 2025

nburns commented Aug 15, 2025

Copy link
Copy Markdown
Contributor Author

@orsenthil and everyone else, just wanted to say thanks for working with me on my first contribution to Python ❤️

Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull request Aug 19, 2025
pythongh-92936: update http.cookies docs post pythonGH-113663 (pyth…
a93c7c1 
…on#137566)

* add versionchanged and example with quotes in cookie value

* update whatsnew with http.cookies change

* Update Doc/library/http.cookies.rst

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>

* Update Doc/whatsnew/3.15.rst

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>

* spelling, quote

* demonstrate json

* Update Doc/library/http.cookies.rst

Co-authored-by: Senthil Kumaran <senthil@python.org>

* Apply suggestions from code review

Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>

* shorter description

---------

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
Co-authored-by: Senthil Kumaran <senthil@python.org>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
KowalskiThomas mentioned this pull request Apr 28, 2026
Closed
serhiy-storchaka mentioned this pull request Apr 30, 2026
Merged
serhiy-storchaka added a commit that referenced this pull request Apr 30, 2026
gh-149028: Revert gh-92936 changes (GH-149182)
c80e446 
* Revert "gh-92936: update `http.cookies` docs post GH-113663 (#137566)"

This reverts commit d86c225.

* Revert "gh-92936: allow double quote in cookie values (#113663)"

This reverts commit d7dbde8.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

orsenthil orsenthil approved these changes
AA-Turner AA-Turner left review comments
picnixz picnixz left review comments

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL