Repository navigation
gh-149028: Revert gh-92936 changes - #149182
Merged
serhiy-storchaka merged 2 commits intoApr 30, 2026
Merged
serhiy-storchaka merged 2 commits into
serhiy-storchaka merged 2 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
… (python#137566)" This reverts commit d86c225.
Copy link
Copy Markdown
Documentation build overview4 files changed ± contents.html ± download.html ± library/http.cookies.html ± whatsnew/3.15.html |
Sorry, something went wrong.
tim-one
approved these changes
Apr 30, 2026
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Absolutely. To summarize why, the original change:
- Opened the door to a new exponential-time reDOS attack.
- Wasn't well defined: it allowed for ambiguous inputs. This can't be repaired (trying to remove the meta-meanings of both semicolon and unescapred double quote inside a double-quoted string value makes it impossible in some cases to know when the string was intended to end).
So there's no clear way to preserve the intent of the original change. It's not just a matter of rewriting the implementation - the intent was subtly incoherent.
If something "like" the intent is desired, it requires a different design.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revert "gh-92936: allow double quote in cookie values (#113663)"
This reverts commit d7dbde8.
Revert "gh-92936: update http.cookies docs post GH-113663 (#137566)"
This reverts commit d86c225.