FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-138234: clarify returncode behavior for subprocess_exec vs subprocess_shell by andreuu-tsai · Pull Request #138536 · python/cpython · GitHub

/ cpython Public

gh-138234: clarify returncode behavior for subprocess_exec vs subprocess_shell - #138536

Merged
kumaraditya303 merged 3 commits into
python:mainfrom
andreuu-tsai:doc-asyncio-subprocess-returncode-in-shell
Mar 21, 2026
ConversationCommits (3)ChecksFiles changed
Merged

gh-138234: clarify returncode behavior for subprocess_exec vs subprocess_shell#138536
kumaraditya303 merged 3 commits into
python:mainfrom
andreuu-tsai:doc-asyncio-subprocess-returncode-in-shell

Conversation

andreuu-tsai commented Sep 5, 2025 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Contributor

Update asyncio.subprocess returncode documentation:

  • For create_subprocess_exec, negative values (-N) indicate termination by signal N (POSIX).
  • For create_subprocess_shell, the return code follows the invoked shell’s exit status (e.g. 128+N for signals in bash/sh).

📚 Documentation preview 📚: https://cpython-previews--138536.org.readthedocs.build/

python-cla-bot Bot commented Sep 5, 2025 •
edited
Loading

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.

bedevere-app Bot added docs Documentation in the Doc dir skip news labels Sep 5, 2025
github-project-automation Bot moved this to Todo in Docs PRs Sep 5, 2025
bedevere-app Bot mentioned this pull request Sep 5, 2025
Closed
andreuu-tsai force-pushed the doc-asyncio-subprocess-returncode-in-shell branch from b833aaf to 93cdda2 Compare September 5, 2025 09:44
gpshead reviewed Sep 6, 2025
View reviewed changes

gpshead left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

there are several places in subprocess.rst itself that could be updated in a similar manner to mention the potential difference between shell=False (default) and shell=True.

kumaraditya303 requested changes Oct 3, 2025
View reviewed changes

kumaraditya303 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

awaiting subprocess docs changes and CLA

bedevere-app Bot commented Oct 3, 2025

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

docs: clarify returncode behavior for subprocess_exec vs subprocess_s…
979128f 
…hell

Update asyncio.subprocess returncode documentation:
- For create_subprocess_exec, negative values (-N) indicate termination by signal N (POSIX).
- For create_subprocess_shell, the return code follows the invoked shell’s exit status
  (e.g. 128+N for signals in bash/sh).
andreuu-tsai force-pushed the doc-asyncio-subprocess-returncode-in-shell branch from 5fac6df to 979128f Compare October 6, 2025 13:10
kumaraditya303 enabled auto-merge (squash) March 21, 2026 12:16
kumaraditya303 added topic-asyncio needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Mar 21, 2026
kumaraditya303 merged commit 8a531f8 into python:main Mar 21, 2026
28 checks passed
github-project-automation Bot moved this from Todo to Done in Docs PRs Mar 21, 2026

miss-islington-app Bot commented Mar 21, 2026

Copy link
Copy Markdown

Thanks @andreuu-tsai for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 21, 2026
pythongh-138234: clarify returncode behavior for subprocesses created…
f31b87a 
… with `shell=True` (pythonGH-138536)

(cherry picked from commit 8a531f8)

Co-authored-by: andreuu-tsai <32549555+andreuu-tsai@users.noreply.github.com>
Co-authored-by: Kumar Aditya <kumaraditya@python.org>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 21, 2026
pythongh-138234: clarify returncode behavior for subprocesses created…
bbaac99 
… with `shell=True` (pythonGH-138536)

(cherry picked from commit 8a531f8)

Co-authored-by: andreuu-tsai <32549555+andreuu-tsai@users.noreply.github.com>
Co-authored-by: Kumar Aditya <kumaraditya@python.org>

bedevere-app Bot commented Mar 21, 2026

Copy link
Copy Markdown

GH-146254 is a backport of this pull request to the 3.14 branch.

bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Mar 21, 2026

bedevere-app Bot commented Mar 21, 2026

Copy link
Copy Markdown

GH-146255 is a backport of this pull request to the 3.13 branch.

bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Mar 21, 2026
kumaraditya303 added a commit that referenced this pull request Mar 21, 2026
[3.14] gh-138234: clarify returncode behavior for subprocesses create…
f2c7024 
…d with `shell=True` (GH-138536) (#146254)

gh-138234: clarify returncode behavior for subprocesses created with `shell=True` (GH-138536)
(cherry picked from commit 8a531f8)

Co-authored-by: andreuu-tsai <32549555+andreuu-tsai@users.noreply.github.com>
Co-authored-by: Kumar Aditya <kumaraditya@python.org>
kumaraditya303 added a commit that referenced this pull request Mar 21, 2026
[3.13] gh-138234: clarify returncode behavior for subprocesses create…
29303db 
…d with `shell=True` (GH-138536) (#146255)

gh-138234: clarify returncode behavior for subprocesses created with `shell=True` (GH-138536)
(cherry picked from commit 8a531f8)

Co-authored-by: andreuu-tsai <32549555+andreuu-tsai@users.noreply.github.com>
Co-authored-by: Kumar Aditya <kumaraditya@python.org>
CuriousLearner added a commit to CuriousLearner/cpython that referenced this pull request Mar 22, 2026
Merge remote-tracking branch 'upstream/main' into fix-pythongh-138577
2691ad9 
* upstream/main: (1475 commits)
  Docs: replace all `datetime` imports with `import datetime as dt` (python#145640)
  pythongh-146153: Use `frozendict` in pure python fallback for `curses.has_key` (python#146154)
  pythongh-138234: clarify returncode behavior for subprocesses created with `shell=True` (python#138536)
  pythongh-140947: fix contextvars handling for server tasks in asyncio  (python#141158)
  pythonGH-100108: Add async generators best practices section (python#141885)
  pythonGH-145667: Merge `GET_ITER` and `GET_YIELD_FROM_ITER` (pythonGH-146120)
  pythongh-146228: Better fork support in cached FastPath (python#146231)
  pythongh-146227: Fix wrong type in _Py_atomic_load_uint16 in pyatomic_std.h (pythongh-146229)
  pythongh-145980: Fix copy/paste mistake in binascii.c (python#146230)
  pythongh-146092: Raise MemoryError on allocation failure in _zoneinfo (python#146165)
  pythongh-91279: Note `SOURCE_DATE_EPOCH` support in `ZipFile.writestr()` doc (python#139396)
  pythongh-146196: Fix Undefined Behavior in _PyUnicodeWriter_WriteASCIIString() (python#146201)
  pythongh-143930: Reject leading dashes in webbrowser URLs
  pythongh-145916: Soft-deprecate ctypes.util.find_library (pythonGH-145919)
  pythongh-146205: Check the errno with != 0 in close impls in select module (python#146206)
  pythongh-146171: Fix nested AttributeError suggestions (python#146188)
  pythongh-146099: Optimize _GUARD_CODE_VERSION+IP via function version symbols (pythonGH-146101)
  pythongh-145980: Add support for alternative alphabets in the binascii module (pythonGH-145981)
  pythongh-145754: Update signature retrieval in unittest.mock to use forwardref annotation format (python#145756)
  pythongh-145177: Add emscripten run --test, uses test args from config.toml (python#146160)
  ...
gpshead reviewed Mar 22, 2026
View reviewed changes

gpshead left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

thanks!

pablogsal mentioned this pull request Apr 4, 2026
Merged
ljfp pushed a commit to ljfp/cpython that referenced this pull request Apr 25, 2026
pythongh-138234: clarify returncode behavior for subprocesses created…
f797cd5 
… with `shell=True` (python#138536)

Co-authored-by: Kumar Aditya <kumaraditya@python.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

gpshead gpshead left review comments
kumaraditya303 kumaraditya303 approved these changes
1st1 Awaiting requested review from 1st1 1st1 is a code owner
asvetlov Awaiting requested review from asvetlov asvetlov is a code owner
willingc Awaiting requested review from willingc willingc is a code owner

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news topic-asyncio

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL