gh-146227: Fix wrong type in _Py_atomic_load_uint16 in pyatomic_std.h - #146229
Merged
colesbury merged 1 commit intoMar 20, 2026
Merged
gh-146227: Fix wrong type in _Py_atomic_load_uint16 in pyatomic_std.h#146229colesbury merged 1 commit into
colesbury merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
…_std.h Also fix a few related issues in the pyatomic headers: * Fix _Py_atomic_store_uint_release in pyatomic_msc.h to use __stlr32 on ARM64 instead of a plain volatile store (which is only relaxed on ARM64). * Add missing _Py_atomic_store_uint_release to pyatomic_gcc.h. * Fix pseudo-code comment for _Py_atomic_store_ptr_release in pyatomic.h.
colesbury
marked this pull request as ready for review
March 20, 2026 17:24
corona10
approved these changes
Mar 20, 2026
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
lgtm
Sorry, something went wrong.
Copy link
Copy Markdown
|
Thanks @colesbury for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
Sorry, something went wrong.
Copy link
Copy Markdown
|
Sorry, @colesbury, I could not cleanly backport this to 3.14 due to a conflict. cherry_picker 1eff27f2c0452b3114bcf139062c87c025842c3e 3.14 |
Sorry, something went wrong.
Copy link
Copy Markdown
|
Sorry, @colesbury, I could not cleanly backport this to 3.13 due to a conflict. cherry_picker 1eff27f2c0452b3114bcf139062c87c025842c3e 3.13 |
Sorry, something went wrong.
colesbury
added a commit
to colesbury/cpython
that referenced
this pull request
Mar 20, 2026
…yatomic_std.h (pythongh-146229) Also fix a few related issues in the pyatomic headers: * Fix _Py_atomic_store_uint_release in pyatomic_msc.h to use __stlr32 on ARM64 instead of a plain volatile store (which is only relaxed on ARM64). * Add missing _Py_atomic_store_uint_release to pyatomic_gcc.h. * Fix pseudo-code comment for _Py_atomic_store_ptr_release in pyatomic.h. (cherry picked from commit 1eff27f) Co-authored-by: Sam Gross <colesbury@gmail.com>
Copy link
Copy Markdown
|
GH-146232 is a backport of this pull request to the 3.14 branch. |
Sorry, something went wrong.
colesbury
added a commit
to colesbury/cpython
that referenced
this pull request
Mar 20, 2026
…yatomic_std.h (pythongh-146229) Also fix a few related issues in the pyatomic headers: * Fix _Py_atomic_store_uint_release in pyatomic_msc.h to use __stlr32 on ARM64 instead of a plain volatile store (which is only relaxed on ARM64). * Add missing _Py_atomic_store_uint_release to pyatomic_gcc.h. * Fix pseudo-code comment for _Py_atomic_store_ptr_release in pyatomic.h. (cherry picked from commit 1eff27f) Co-authored-by: Sam Gross <colesbury@gmail.com>
Copy link
Copy Markdown
|
GH-146233 is a backport of this pull request to the 3.13 branch. |
Sorry, something went wrong.
colesbury
added a commit
that referenced
this pull request
Mar 20, 2026
…c_std.h (gh-146229) (#146232) Also fix a few related issues in the pyatomic headers: * Fix _Py_atomic_store_uint_release in pyatomic_msc.h to use __stlr32 on ARM64 instead of a plain volatile store (which is only relaxed on ARM64). * Add missing _Py_atomic_store_uint_release to pyatomic_gcc.h. * Fix pseudo-code comment for _Py_atomic_store_ptr_release in pyatomic.h. (cherry picked from commit 1eff27f)
colesbury
added a commit
that referenced
this pull request
Mar 20, 2026
CuriousLearner
added a commit
to CuriousLearner/cpython
that referenced
this pull request
Mar 22, 2026
* upstream/main: (1475 commits) Docs: replace all `datetime` imports with `import datetime as dt` (python#145640) pythongh-146153: Use `frozendict` in pure python fallback for `curses.has_key` (python#146154) pythongh-138234: clarify returncode behavior for subprocesses created with `shell=True` (python#138536) pythongh-140947: fix contextvars handling for server tasks in asyncio (python#141158) pythonGH-100108: Add async generators best practices section (python#141885) pythonGH-145667: Merge `GET_ITER` and `GET_YIELD_FROM_ITER` (pythonGH-146120) pythongh-146228: Better fork support in cached FastPath (python#146231) pythongh-146227: Fix wrong type in _Py_atomic_load_uint16 in pyatomic_std.h (pythongh-146229) pythongh-145980: Fix copy/paste mistake in binascii.c (python#146230) pythongh-146092: Raise MemoryError on allocation failure in _zoneinfo (python#146165) pythongh-91279: Note `SOURCE_DATE_EPOCH` support in `ZipFile.writestr()` doc (python#139396) pythongh-146196: Fix Undefined Behavior in _PyUnicodeWriter_WriteASCIIString() (python#146201) pythongh-143930: Reject leading dashes in webbrowser URLs pythongh-145916: Soft-deprecate ctypes.util.find_library (pythonGH-145919) pythongh-146205: Check the errno with != 0 in close impls in select module (python#146206) pythongh-146171: Fix nested AttributeError suggestions (python#146188) pythongh-146099: Optimize _GUARD_CODE_VERSION+IP via function version symbols (pythonGH-146101) pythongh-145980: Add support for alternative alphabets in the binascii module (pythonGH-145981) pythongh-145754: Update signature retrieval in unittest.mock to use forwardref annotation format (python#145756) pythongh-145177: Add emscripten run --test, uses test args from config.toml (python#146160) ...
ljfp
pushed a commit
to ljfp/cpython
that referenced
this pull request
Apr 25, 2026
…_std.h (pythongh-146229) Also fix a few related issues in the pyatomic headers: * Fix _Py_atomic_store_uint_release in pyatomic_msc.h to use __stlr32 on ARM64 instead of a plain volatile store (which is only relaxed on ARM64). * Add missing _Py_atomic_store_uint_release to pyatomic_gcc.h. * Fix pseudo-code comment for _Py_atomic_store_ptr_release in pyatomic.h.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also fix a few related issues in the pyatomic headers: