gh-133059: fix Tools/build/deepfreeze.py nsmallposints - #139906
Conversation
Sorry, something went wrong.
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead. |
Sorry, something went wrong.
| import os | ||
|
|
||
| SCRIPT_NAME = 'Tools/build/consts_getter.py' | ||
| __file__ = os.path.abspath(__file__) |
There was a problem hiding this comment.
Why do you redefine __file__?
Sorry, something went wrong.
|
|
||
| SCRIPT_NAME = 'Tools/build/consts_getter.py' | ||
| __file__ = os.path.abspath(__file__) | ||
| ROOT = os.path.dirname(os.path.dirname(os.path.dirname(__file__))) |
There was a problem hiding this comment.
What about builds that are performed in a different folder? It is possible to do that.
Sorry, something went wrong.
There was a problem hiding this comment.
these constants were stolen from Tools/build/generate_global_objects.py, so in this case I think it will be more than enough not to override __file__ and just specify a valid path to Include's
Sorry, something went wrong.
| @@ -0,0 +1,22 @@ | |||
| import os | |||
|
|
|||
| SCRIPT_NAME = 'Tools/build/consts_getter.py' | |||
There was a problem hiding this comment.
Is it needed?
Sorry, something went wrong.
There was a problem hiding this comment.
in this case, I think it's not. it's only used in scripts that generate .c files to put a comment on top to indicate that those file were generated by this particular script
will remove
Sorry, something went wrong.
Eclips4
left a comment
There was a problem hiding this comment.
I have one minor comment, otherwise LGTM.
Sorry, something went wrong.
Co-authored-by: Kirill Podoprigora <kirill.bast9@mail.ru>
efimov-mikhail
left a comment
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
|
Thank you Albert! |
Sorry, something went wrong.
In Tools/build/deepfreeze.py nsmallposints was still 256.
Although deepfreeze is no longer used (#116919), this script still needs to be kept and be actual until it is completely removed.
This PR steals the parser of those numbers from Tools/build/generate_global_objects.py and puts it in a new script, so getting constants can be unified.