FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-139817: Attribute `__qualname__` is added to `TypeAliasType` by efimov-mikhail · Pull Request #139919 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-139817: Attribute __qualname__ is added to TypeAliasType - #139919

Merged
JelleZijlstra merged 8 commits into
python:mainfrom
efimov-mikhail:issue-139817-type-alias-qualname
Oct 15, 2025
ConversationCommits (8)ChecksFiles changed
Merged

gh-139817: Attribute __qualname__ is added to TypeAliasType#139919
JelleZijlstra merged 8 commits into
python:mainfrom
efimov-mikhail:issue-139817-type-alias-qualname

Conversation

efimov-mikhail commented Oct 10, 2025 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

bedevere-app Bot mentioned this pull request Oct 10, 2025
Closed
efimov-mikhail changed the title gh-139817: Parameter __qualname__ is added to TypeAliasType gh-139817: Attribute __qualname__ is added to TypeAliasType Oct 10, 2025

efimov-mikhail commented Oct 10, 2025

Copy link
Copy Markdown
Member Author

CC @sobolevn

efimov-mikhail commented Oct 10, 2025

Copy link
Copy Markdown
Member Author

I'm totally not sure that this solution is fully correct.
But it works in typical situations, and improves introspection.

JelleZijlstra reviewed Oct 11, 2025
View reviewed changes

JelleZijlstra left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks!

Comment thread Objects/typevarobject.c
Comment thread Objects/typevarobject.c
Comment thread Lib/test/test_type_aliases.py

efimov-mikhail commented Oct 11, 2025

Copy link
Copy Markdown
Member Author

I've added some tests on __name__ and __qualname__, docs and news

AlexWaygood removed their request for review October 11, 2025 23:56
JelleZijlstra reviewed Oct 12, 2025
View reviewed changes
Comment thread Objects/typevarobject.c Outdated

efimov-mikhail commented Oct 12, 2025

Copy link
Copy Markdown
Member Author

I've added new constructor parameter: X = TypeAliasType("X", int, qualname="foo.X"). It looks like there is no much extra complexity and this solution is OK. But we can provide another variant, if it's needed.

JelleZijlstra reviewed Oct 12, 2025
View reviewed changes
Comment thread Objects/typevarobject.c
efimov-mikhail mentioned this pull request Oct 12, 2025
Merged

efimov-mikhail commented Oct 15, 2025 •
edited
Loading

Copy link
Copy Markdown
Member Author

Sorry for ping, @JelleZijlstra.

This PR could be merged, or I've missed something?

JelleZijlstra merged commit f673f0e into python:main Oct 15, 2025
45 checks passed

efimov-mikhail commented Oct 15, 2025

Copy link
Copy Markdown
Member Author

Thanks!

StanFromIreland pushed a commit to StanFromIreland/cpython that referenced this pull request Dec 6, 2025
pythongh-139817: Attribute __qualname__ is added to TypeAliasType (…
13369a1 
…python#139919)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

JelleZijlstra Awaiting requested review from JelleZijlstra JelleZijlstra is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL