FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-140000: Traverse `name` attribute for `TypeVar`, `TypeVarTuple`, `TypeAliasType`, `ParamSpec` by efimov-mikhail · Pull Request #140016 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-140000: Traverse name attribute for TypeVar, TypeVarTuple, TypeAliasType, ParamSpec - #140016

Merged
JelleZijlstra merged 2 commits into
python:mainfrom
efimov-mikhail:issue-140000-str-leak
Oct 13, 2025
ConversationCommits (2)ChecksFiles changed
Merged

gh-140000: Traverse name attribute for TypeVar, TypeVarTuple, TypeAliasType, ParamSpec#140016
JelleZijlstra merged 2 commits into
python:mainfrom
efimov-mikhail:issue-140000-str-leak

Conversation

efimov-mikhail commented Oct 12, 2025 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

I'm not sure should we add tests on these.
But I've checked code snippet from the issue on all 4 types, they work as expected.

IMO, it'd be better to merge this PR first and provide a backports for 3.14 and 3.13.
We could merge #139919 after this (qualname traversing will be there).

cc @JelleZijlstra

efimov-mikhail changed the title Traverse name attribute for TypeVar, TypeVarTuple, TypeAliasType, ParamSpec gh-140000: Traverse name attribute for TypeVar, TypeVarTuple, TypeAliasType, ParamSpec Oct 12, 2025
bedevere-app Bot mentioned this pull request Oct 12, 2025
Closed
JelleZijlstra reviewed Oct 13, 2025
View reviewed changes
Comment thread Objects/typevarobject.c
JelleZijlstra added needs backport to 3.13 only security fixes needs backport to 3.14 bugs and security fixes labels Oct 13, 2025

efimov-mikhail commented Oct 13, 2025

Copy link
Copy Markdown
Member Author

I've added news entry, CI is green

JelleZijlstra merged commit be60e4b into python:main Oct 13, 2025
53 checks passed

miss-islington-app Bot commented Oct 13, 2025

Copy link
Copy Markdown

Thanks @efimov-mikhail for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 13, 2025
pythongh-140000: Traverse name attribute for TypeVar, `TypeVarTup…
6e92029 
…le`, `TypeAliasType`, `ParamSpec` (pythonGH-140016)

(cherry picked from commit be60e4b)

Co-authored-by: Mikhail Efimov <efimov.mikhail@gmail.com>

miss-islington-app Bot commented Oct 13, 2025

Copy link
Copy Markdown

Sorry, @efimov-mikhail and @JelleZijlstra, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker be60e4b4f34a097d999d337446786ae14e35c964 3.13

bedevere-app Bot commented Oct 13, 2025

Copy link
Copy Markdown

GH-140063 is a backport of this pull request to the 3.14 branch.

bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Oct 13, 2025
JelleZijlstra pushed a commit that referenced this pull request Oct 13, 2025
[3.14] gh-140000: Traverse name attribute for TypeVar, `TypeVarTu…
7a13953 
…ple`, `TypeAliasType`, `ParamSpec` (GH-140016) (#140063)

gh-140000: Traverse `name` attribute for `TypeVar`, `TypeVarTuple`, `TypeAliasType`, `ParamSpec` (GH-140016)
(cherry picked from commit be60e4b)

Co-authored-by: Mikhail Efimov <efimov.mikhail@gmail.com>

bedevere-app Bot commented Oct 14, 2025

Copy link
Copy Markdown

GH-140073 is a backport of this pull request to the 3.13 branch.

bedevere-app Bot removed the needs backport to 3.13 only security fixes label Oct 14, 2025
JelleZijlstra pushed a commit that referenced this pull request Oct 14, 2025
[3.13] gh-140000: Traverse name attribute for TypeVar, `TypeVarTu…
cbcee9a 
…ple`, `TypeAliasType`, `ParamSpec` (GH-140016) (#140073)

Correct traversing name attribute for TypeVar, TypeVarTuple, TypeAliasType, ParamSpec
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

sergey-miryanov sergey-miryanov approved these changes
kumaraditya303 kumaraditya303 approved these changes
JelleZijlstra Awaiting requested review from JelleZijlstra JelleZijlstra is a code owner

Assignees

JelleZijlstra

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL