FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Update documented minimum required zlib library version by StanFromIreland · Pull Request #140116 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

Update documented minimum required zlib library version - #140116

Merged
vstinner merged 2 commits into
python:mainfrom
StanFromIreland:zlib-ver
Oct 14, 2025
ConversationCommits (2)ChecksFiles changed
Merged

Update documented minimum required zlib library version#140116
vstinner merged 2 commits into
python:mainfrom
StanFromIreland:zlib-ver

Conversation

StanFromIreland commented Oct 14, 2025 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member

bedevere-app Bot added docs Documentation in the Doc dir skip news awaiting review labels Oct 14, 2025
github-project-automation Bot moved this to Todo in Docs PRs Oct 14, 2025
StanFromIreland commented Oct 14, 2025
View reviewed changes
Comment thread Doc/using/configure.rst

* `libb2 <https://github.com/BLAKE2/libb2>`_ (:ref:`BLAKE2 <hashlib-blake2>`),
used by :mod:`hashlib` module.
* `libb2 <https://github.com/BLAKE2/libb2>`_ (:ref:`BLAKE2 <hashlib-blake2>`)

StanFromIreland Oct 14, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I removed some unnecessary commas here.

StanFromIreland commented Oct 14, 2025
View reviewed changes
Comment thread Doc/library/zlib.rst
incompatibilities between the Python module and versions of the zlib library
earlier than 1.1.3; 1.1.3 has a `security vulnerability <https://zlib.net/zlib_faq.html#faq33>`_, so we recommend using
1.1.4 or later.
has its own home page at https://www.zlib.net. zlib 1.2.2.1 is the minium

StanFromIreland Oct 14, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This was wrong for a while:

cpython/Modules/zlibmodule.c

Lines 16 to 18 in 59547a2

#if defined(ZLIB_VERNUM) && ZLIB_VERNUM < 0x1221
#error "At least zlib version 1.2.2.1 is required"
#endif

vstinner reviewed Oct 14, 2025
View reviewed changes
Comment thread Doc/using/configure.rst
* `Tcl/Tk <https://www.tcl-lang.org/>`_ 8.5.12 for the :mod:`tkinter` module.

* `zlib <https://www.zlib.net>`_ 1.1.4 is the reccomended minimum version for the
* `zlib <https://www.zlib.net>`_ 1.2.2.1 is the minimum version for the

vstinner Oct 14, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

zlib 1.2.2.0 was released in 2004: https://madler.net/pipermail/zlib-announce_madler.net/2004/000002.html. So it sounds reasonable to require this (old) version.

StanFromIreland Oct 14, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

As I noted here, it is required by the code. One will get an error otherwise.

vstinner approved these changes Oct 14, 2025
View reviewed changes

vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

emmatyping approved these changes Oct 14, 2025
View reviewed changes

emmatyping left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks!

vstinner merged commit 2ca3c85 into python:main Oct 14, 2025
79 of 81 checks passed
github-project-automation Bot moved this from Todo to Done in Docs PRs Oct 14, 2025

vstinner commented Oct 14, 2025

Copy link
Copy Markdown
Member

Merged, thanks.

StanFromIreland deleted the zlib-ver branch October 15, 2025 06:22

encukou commented Nov 10, 2025

Copy link
Copy Markdown
Member

#141204 effectively backports this to 3.14.

StanFromIreland added a commit to StanFromIreland/cpython that referenced this pull request Dec 6, 2025
Update documented minimum required zlib library version (python#140116)
8889bd8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

vstinner vstinner approved these changes
emmatyping emmatyping approved these changes
erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland is a code owner
corona10 Awaiting requested review from corona10 corona10 is a code owner
AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip issue skip news

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL