Repository navigation
[3.14] gh-139707: Add docs for optional modules (GH-140171) - #141204
Merged
encukou merged 1 commit intoNov 10, 2025
Merged
encukou merged 1 commit into
encukou merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
(cherry picked from commit d2ce6d7) Co-authored-by: Petr Viktorin <encukou@gmail.com> Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com> Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com> Co-authored-by: Emma Smith <emma@emmatyping.dev> Co-authored-by: Author: Terry Jan Reedy <tjreedy@udel.edu> Co-authored-by: Victor Stinner <vstinner@python.org>
StanFromIreland
requested review from
berkerpeksag,
corona10,
erlend-aasland,
ethanfurman,
gpshead,
pfmoore,
picnixz,
pradyunsg and
terryjreedy
as code owners
November 7, 2025 16:20
StanFromIreland
commented
Nov 7, 2025
Comment thread
Doc/library/zlib.rst
| has its own home page at https://www.zlib.net. There are known | ||
| incompatibilities between the Python module and versions of the zlib library | ||
| earlier than 1.1.3; 1.1.3 has a `security vulnerability <https://zlib.net/zlib_faq.html#faq33>`_, so we recommend using | ||
| 1.1.4 or later. |
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment.
This was the conflict, I recently bumped this to the actual minimum (we error during building otherwise), it wasn't backported but there is no difference on 3.14, I can change it if we prefer to keep it at (the technically impossible) 1.1.4.
Lines 16 to 18 in 9f8ec95
Sorry, something went wrong.
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Sounds good!
You're effectively backporting the other docs fix. I mentioned this PR on your earlier one.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit d2ce6d7)
📚 Documentation preview 📚: https://cpython-previews--141204.org.readthedocs.build/