FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-83714: Check for struct statx.stx_atomic_write_unit_max_opt in configure by jbosboom · Pull Request #140185 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-83714: Check for struct statx.stx_atomic_write_unit_max_opt in configure - #140185

Merged
vstinner merged 1 commit into
python:mainfrom
jbosboom:statx-atomic-write-unit-max-opt
Oct 16, 2025
ConversationCommits (1)ChecksFiles changed
Merged

gh-83714: Check for struct statx.stx_atomic_write_unit_max_opt in configure#140185
vstinner merged 1 commit into
python:mainfrom
jbosboom:statx-atomic-write-unit-max-opt

Conversation

jbosboom commented Oct 16, 2025 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Contributor

stx_atomic_write_unit_max_opt was added in Linux 6.16, but is controlled by the STATX_WRITE_ATOMIC mask bit added in Linux 6.11. That's safe at runtime because all kernels clear the reserved space in struct statx and zero is a valid value for stx_atomic_write_unit_max_opt, and it avoids allocating another mask bit, which are a limited resource. But it also means the kernel headers don't provide a way to check whether stx_atomic_write_unit_max_opt exists, so add a configure check.

I ran make regen-configure. I know very little about autoconf, so please check I didn't mess up.

📚 Documentation preview 📚: https://cpython-previews--140185.org.readthedocs.build/

Check for struct statx.stx_atomic_write_unit_max_opt in configure
37ebb56 
stx_atomic_write_unit_max_opt was added in Linux 6.16, but is controlled
by the STATX_WRITE_ATOMIC mask bit added in Linux 6.11.  That's safe at
runtime because all kernels clear the reserved space in struct statx and
zero is a valid value for stx_atomic_write_unit_max_opt, and it avoids
allocating another mask bit, which are a limited resource.  But it also
means the kernel headers don't provide a way to check whether
stx_atomic_write_unit_max_opt exists, so add a configure check.
bedevere-app Bot mentioned this pull request Oct 16, 2025
Closed

jbosboom commented Oct 16, 2025

Copy link
Copy Markdown
Contributor Author

!buildbot AMD64 CentOS9 NoGIL 3.x

bedevere-bot commented Oct 16, 2025

Copy link
Copy Markdown

You don't have write permissions to trigger a build

jbosboom mentioned this pull request Oct 16, 2025
Merged

jbosboom commented Oct 16, 2025

Copy link
Copy Markdown
Contributor Author

#139178 failed on the AMD64 CentOS9 NoGIL 3.x (tier-1), ARM64 Raspbian Debug 3.x (tier-3) and ARM Raspbian 3.x (tier-3) buildbots. I need someone with the appropriate permissions to run those before merging.

This should be skip-news.

cmaloney reviewed Oct 16, 2025
View reviewed changes

cmaloney left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This seems like a reasonable approach to me; a core dev can trigger the bots to validate (although the queue can take a while to get to the top of).

I think skip news works as this is falls under "If a change is a fix (or other adjustment) to an earlier unreleased change and the original NEWS entry remains valid, then no additional entry is needed."

This comment was marked as outdated.

Sign in to view

This comment was marked as outdated.

Sign in to view

This comment was marked as outdated.

Sign in to view
1 similar comment

encukou commented Oct 16, 2025

Copy link
Copy Markdown
Member

!buildbot AMD64.CentOS9.NoGIL

bedevere-bot commented Oct 16, 2025

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @encukou for commit 37ebb56 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F140185%2Fmerge

The command will test the builders whose names match following regular expression: AMD64.CentOS9.NoGIL

The builders matched are:

  • AMD64 CentOS9 NoGIL PR
  • AMD64 CentOS9 NoGIL Refleaks PR

vstinner approved these changes Oct 16, 2025
View reviewed changes

vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM, but let me check on buildbots.

vstinner commented Oct 16, 2025

Copy link
Copy Markdown
Member

!buildbot Raspbian

bedevere-bot commented Oct 16, 2025

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @vstinner for commit 37ebb56 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F140185%2Fmerge

The command will test the builders whose names match following regular expression: Raspbian

The builders matched are:

  • ARM Raspbian Linux Asan PR
  • ARM64 Raspbian Debug PR
  • ARM Raspbian PR
  • ARM64 Raspbian PR

encukou commented Oct 16, 2025

Copy link
Copy Markdown
Member

Buildbot issues to expect:

vstinner commented Oct 16, 2025

Copy link
Copy Markdown
Member

Buildbots passed successfully:

  • buildbot/AMD64 CentOS9 NoGIL PR
  • buildbot/ARM Raspbian PR
  • buildbot/ARM64 Raspbian Debug PR
  • buildbot/ARM64 Raspbian PR

Buildbot issues to expect: The refleak in test_type_aliases was #140197.

Alright, AMD64 CentOS9 NoGIL Refleaks PR failed on an unrelated test: test_type_aliases leaked [1, 1, 1] references, sum=3.

vstinner merged commit 5a31024 into python:main Oct 16, 2025
58 of 59 checks passed

vstinner commented Oct 16, 2025

Copy link
Copy Markdown
Member

Merged, thanks @jbosboom.

jbosboom mentioned this pull request Oct 21, 2025
Merged
StanFromIreland pushed a commit to StanFromIreland/cpython that referenced this pull request Dec 6, 2025
pythongh-83714: Check for struct statx.stx_atomic_write_unit_max_opt …
4215e46 
…in configure (python#140185)

stx_atomic_write_unit_max_opt was added in Linux 6.16, but is controlled
by the STATX_WRITE_ATOMIC mask bit added in Linux 6.11.  That's safe at
runtime because all kernels clear the reserved space in struct statx and
zero is a valid value for stx_atomic_write_unit_max_opt, and it avoids
allocating another mask bit, which are a limited resource.  But it also
means the kernel headers don't provide a way to check whether
stx_atomic_write_unit_max_opt exists, so add a configure check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

cmaloney cmaloney left review comments
vstinner vstinner approved these changes
erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland is a code owner
corona10 Awaiting requested review from corona10 corona10 is a code owner
AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner
emmatyping Awaiting requested review from emmatyping emmatyping is a code owner

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL