FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-139817: Fix refleak in TypeAliasType(qualname=non_string) by encukou · Pull Request #140197 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-139817: Fix refleak in TypeAliasType(qualname=non_string) - #140197

Merged
encukou merged 2 commits into
python:mainfrom
encukou:gh-139817-leak
Oct 16, 2025
ConversationCommits (2)ChecksFiles changed
Merged

gh-139817: Fix refleak in TypeAliasType(qualname=non_string)#140197
encukou merged 2 commits into
python:mainfrom
encukou:gh-139817-leak

Conversation

encukou commented Oct 16, 2025 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

bedevere-app Bot mentioned this pull request Oct 16, 2025
Closed

encukou commented Oct 16, 2025

Copy link
Copy Markdown
Member Author

!buildbot AMD64.Fedora.Stable.Refleaks

bedevere-bot commented Oct 16, 2025

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @encukou for commit 8c46640 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F140197%2Fmerge

The command will test the builders whose names match following regular expression: AMD64.Fedora.Stable.Refleaks

The builders matched are:

  • AMD64 Fedora Stable Refleaks PR

efimov-mikhail approved these changes Oct 16, 2025
View reviewed changes

efimov-mikhail left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM. I've missed this, sorry.

efimov-mikhail reviewed Oct 16, 2025
View reviewed changes
Comment thread Objects/typevarobject.c
Py_DECREF(module);
return NULL;
}
}

efimov-mikhail Oct 16, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

IMO, it's better to place obtaining of module after qualname related if-block and remove a call of Py_DECREF(module).

encukou enabled auto-merge (squash) October 16, 2025 11:00
efimov-mikhail approved these changes Oct 16, 2025
View reviewed changes

efimov-mikhail left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I've tested for the refleak locally, it's gone.

encukou merged commit ea4cc58 into python:main Oct 16, 2025
43 checks passed
encukou mentioned this pull request Oct 16, 2025
Merged
encukou deleted the gh-139817-leak branch October 17, 2025 10:30
StanFromIreland pushed a commit to StanFromIreland/cpython that referenced this pull request Dec 6, 2025
pythongh-139817: Fix refleak in TypeAliasType(qualname=non_string) (p…
fe4b7b7 
…ythonGH-140197)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

efimov-mikhail efimov-mikhail approved these changes
JelleZijlstra Awaiting requested review from JelleZijlstra JelleZijlstra is a code owner

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL