| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
|
See my comment #83714 (comment) for an explanation of this PR. The PR is currently incomplete, it only supports some stx_result members such as st_atime and st_mtime. |
Sorry, something went wrong.
I completed the PR to handle all stx_mask flags. I didn't use these flags: STATX_TYPE Want stx_mode & S_IFMT STATX_MODE Want stx_mode & ~S_IFMT statx manual page, up to date: https://man7.org/linux/man-pages/man2/statx.2.html |
Sorry, something went wrong.
Change the logic to write the comma.
|
@maurycy: Thanks for your review. I updated my PR. |
Sorry, something went wrong.
| STATX_GET_NSEC(st_ctime_ns, stx_ctime, STATX_CTIME) | ||
| STATX_GET_NSEC(st_mtime_ns, stx_mtime, STATX_MTIME) | ||
|
|
||
| /* The low 16 bits of the context pointer are the offset from the start of |
There was a problem hiding this comment.
I know the mask bit itself won't fit in the context pointer on 32-bit, but you could store the mask bit index in the upper 16 bits. For example, STATX_ATIME is 0x20, so you'd store 5 in the upper 16 bits, and recover the mask bit as 1 << i in the getter. That way you'd only need one getter per type, rather than one per member, which is a lot less code.
Sorry, something went wrong.
There was a problem hiding this comment.
(You probably already know, but just in case, you can get the bit index with __builtin_ctz, and both GCC and Clang will evaluate __builtin_ctz at compile time when the arguments are constant.)
Sorry, something went wrong.
There was a problem hiding this comment.
I prefer to avoid bad surprises on 32-bit systems when Linux will get more bits in mask. If all bits of mask are used, there will be no remaining place for an offset. It sounds more future proof to do as i did, one function per member and put the mask and "offset" there.
Sorry, something went wrong.
There was a problem hiding this comment.
Perhaps I wasn't clear. I'm not proposing to store the mask in the context pointer; I'm proposing to store the index of the mask bit, which is a number from 0 to 31. Even if the mask were somehow extended to 64 bits in the future, the index would then be from 0 to 63, which would still easily fit.
CPython doesn't really care about code size, so I'm fine with the way you did it.
Sorry, something went wrong.
There was a problem hiding this comment.
Oh ok. The problem is that I'm not sure that all compilers supported by Python on Linux can compute the bit position at build time.
I don't think that code size is an issue here.
Sorry, something went wrong.
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.