FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-83714: Set os.statx() members to None if missing from stx_mask by vstinner · Pull Request #140216 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-83714: Set os.statx() members to None if missing from stx_mask #140216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vstinner merged 4 commits into from
Oct 20, 2025
Conversation 18 Commits 4 Checks 43 Files changed
Merged

gh-83714: Set os.statx() members to None if missing from stx_mask #140216

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
289f458
gh-83714: Set os.statx() members to None if missing from stx_mask
vstinner Oct 16, 2025
106c5ad
Fix copy/paste mistakes
vstinner Oct 16, 2025
52d7ef2
Fix pystatx_result_repr()
vstinner Oct 16, 2025
ac61fd9
Document None in os.rst
vstinner Oct 20, 2025
File filter

Filter by extension

Filter by extension .c  (1) All 1 file type selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
Prev Previous commit
Next Next commit
Fix pystatx_result_repr() 
Change the logic to write the comma.
  • Loading branch information
vstinner committed Oct 16, 2025
commit 52d7ef25f4d81803ae2f7e607e27020a339ddfba
25 changes: 9 additions & 16 deletions Modules/posixmodule.c
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -3529,31 +3529,24 @@ pystatx_result_repr(PyObject *op)
Py_DECREF(o);
}

if (Py_ARRAY_LENGTH(pystatx_result_members) > 1
&& Py_ARRAY_LENGTH(pystatx_result_getset) > 1) {
WRITE_ASCII(", ");
}

for (size_t i = 0; i < Py_ARRAY_LENGTH(pystatx_result_getset) - 1; ++i) {
PyGetSetDef *d = &pystatx_result_getset[i];
PyObject *o = d->get(op, d->closure);
if (o == NULL) {
goto error;
}
if (o == Py_None) {
continue;
}

if (o != Py_None) {
if (i > 0) {
WRITE_ASCII(", ");
}

WRITE_ASCII(d->name);
WRITE_ASCII("=");
if (PyUnicodeWriter_WriteRepr(writer, o) < 0) {
Py_DECREF(o);
goto error;
}
WRITE_ASCII(", ");
WRITE_ASCII(d->name);
WRITE_ASCII("=");
if (PyUnicodeWriter_WriteRepr(writer, o) < 0) {
Py_DECREF(o);
goto error;
}
Py_DECREF(o);
}

WRITE_ASCII(")");
Expand Down
Loading
Back | FazBrowse Home | New Git URL