FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-141004: soft-deprecate Py_INFINITY macro by skirpichev · Pull Request #141033 · python/cpython · GitHub

/ cpython Public

gh-141004: soft-deprecate Py_INFINITY macro - #141033

Merged
vstinner merged 6 commits into
python:mainfrom
skirpichev:soft-deprecate-Py_INFINITY/141004
Nov 12, 2025
ConversationCommits (6)ChecksFiles changed
Merged

gh-141004: soft-deprecate Py_INFINITY macro#141033
vstinner merged 6 commits into
python:mainfrom
skirpichev:soft-deprecate-Py_INFINITY/141004

Conversation

skirpichev commented Nov 5, 2025 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member

bedevere-app Bot mentioned this pull request Nov 5, 2025
Open

skirpichev commented Nov 5, 2025

Copy link
Copy Markdown
Member Author

Waiting for feedback in the issue thread. I'm planning soft-deprecate also Py_NAN.

skirpichev marked this pull request as ready for review November 6, 2025 03:21
skirpichev requested a review from AA-Turner as a code owner November 6, 2025 03:21
vstinner reviewed Nov 6, 2025
View reviewed changes
Comment thread Doc/whatsnew/3.15.rst Outdated
Apply suggestions from code review
26cab06 
Co-authored-by: Victor Stinner <vstinner@python.org>

skirpichev commented Nov 6, 2025

Copy link
Copy Markdown
Member Author

I'll add docs here too.

vstinner approved these changes Nov 6, 2025
View reviewed changes

vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

skirpichev requested a review from vstinner November 6, 2025 12:55
ZeroIntensity approved these changes Nov 6, 2025
View reviewed changes

ZeroIntensity left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I don't have much of an opinion here, I think this is fine. Would you mind creating a PR for <3.15 documenting this without the deprecation?

ZeroIntensity commented Nov 6, 2025

Copy link
Copy Markdown
Member

(Let's also wait on the C API WG before landing this one.)

skirpichev commented Nov 6, 2025

Copy link
Copy Markdown
Member Author

Would you mind creating a PR for <3.15 documenting this without the deprecation?

See #141145.

ZeroIntensity mentioned this pull request Nov 6, 2025
Merged
skirpichev commented Nov 6, 2025
View reviewed changes
Comment thread Doc/c-api/float.rst Outdated
vstinner merged commit e202673 into python:main Nov 12, 2025
46 checks passed

vstinner commented Nov 12, 2025

Copy link
Copy Markdown
Member

Merged, thank you.

skirpichev deleted the soft-deprecate-Py_INFINITY/141004 branch November 12, 2025 12:47
StanFromIreland pushed a commit to StanFromIreland/cpython that referenced this pull request Dec 6, 2025
pythongh-141004: soft-deprecate Py_INFINITY macro (python#141033)
8aaa240 
Co-authored-by: Victor Stinner <vstinner@python.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

ZeroIntensity ZeroIntensity approved these changes
AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner
vstinner Awaiting requested review from vstinner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL