FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-141004: document Py_INFINITY and Py_NAN macros by skirpichev · Pull Request #141145 · python/cpython · GitHub

/ cpython Public

gh-141004: document Py_INFINITY and Py_NAN macros - #141145

Merged
vstinner merged 6 commits into
python:mainfrom
skirpichev:document-Py_INFINITY/141004
Nov 11, 2025
ConversationCommits (6)ChecksFiles changed
Merged

gh-141004: document Py_INFINITY and Py_NAN macros#141145
vstinner merged 6 commits into
python:mainfrom
skirpichev:document-Py_INFINITY/141004

Conversation

skirpichev commented Nov 6, 2025 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member

skirpichev added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Nov 6, 2025
bedevere-app Bot added awaiting review docs Documentation in the Doc dir skip news labels Nov 6, 2025
github-project-automation Bot moved this to Todo in Docs PRs Nov 6, 2025
bedevere-app Bot mentioned this pull request Nov 6, 2025
Open
skirpichev mentioned this pull request Nov 6, 2025
Merged
ZeroIntensity reviewed Nov 6, 2025
View reviewed changes
Comment thread Doc/c-api/float.rst Outdated
StanFromIreland reviewed Nov 6, 2025
View reviewed changes
Comment thread Doc/c-api/float.rst Outdated
Update Doc/c-api/float.rst
33bbedc 
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
skirpichev commented Nov 7, 2025
View reviewed changes
Comment thread Doc/c-api/float.rst Outdated
skirpichev changed the title gh-141004: document Py_INFINITY macro gh-141004: document Py_INFINITY and Py_NAN macros Nov 10, 2025

skirpichev commented Nov 10, 2025

Copy link
Copy Markdown
Member Author

Deprecation warning was removed, also documented Py_NAN.

ZeroIntensity approved these changes Nov 11, 2025
View reviewed changes

ZeroIntensity left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks for humoring me :)

vstinner merged commit d694474 into python:main Nov 11, 2025
32 checks passed

miss-islington-app Bot commented Nov 11, 2025

Copy link
Copy Markdown

Thanks @skirpichev for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

github-project-automation Bot moved this from Todo to Done in Docs PRs Nov 11, 2025

miss-islington-app Bot commented Nov 11, 2025

Copy link
Copy Markdown

Sorry, @skirpichev and @vstinner, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker d69447445cbacf7537bf59c5c683a3b17060312d 3.14

miss-islington-app Bot commented Nov 11, 2025

Copy link
Copy Markdown

Sorry, @skirpichev and @vstinner, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker d69447445cbacf7537bf59c5c683a3b17060312d 3.13

vstinner commented Nov 11, 2025

Copy link
Copy Markdown
Member

Merged, thanks.

Sadly, automated backports failed :-( Can you try to backport the change manually to 3.14?

skirpichev deleted the document-Py_INFINITY/141004 branch November 11, 2025 10:19

skirpichev commented Nov 11, 2025

Copy link
Copy Markdown
Member Author

That's because #141035 wasn't backported. I think we should.

vstinner commented Nov 11, 2025

Copy link
Copy Markdown
Member

I would prefer to not backport a deprecation like Py_MATH_El.

This comment has been minimized.

Sign in to view

bedevere-app Bot commented Nov 11, 2025

Copy link
Copy Markdown

GH-141399 is a backport of this pull request to the 3.14 branch.

bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Nov 11, 2025
skirpichev added a commit to skirpichev/cpython that referenced this pull request Nov 11, 2025
[3.14] pythongh-141004: document Py_INFINITY and Py_NAN macros (pytho…
d4f56e7 
…nGH-141145)

(cherry picked from commit d694474)

Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>

bedevere-app Bot commented Nov 11, 2025

Copy link
Copy Markdown

GH-141400 is a backport of this pull request to the 3.13 branch.

bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Nov 11, 2025

bedevere-bot commented Nov 11, 2025

Copy link
Copy Markdown

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Fedora Stable Refleaks 3.x (tier-1) has failed when building commit d694474.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/320/builds/3289) and take a look at the build logs.
  4. Check if the failure is related to this commit (d694474) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/320/builds/3289

Failed tests:

  • test.test_multiprocessing_fork.test_processes

Failed subtests:

  • test_interrupt - test.test_multiprocessing_fork.test_processes.WithProcessesTestProcess.test_interrupt

Summary of the results of the build (if available):

==

Click to see traceback logs 
Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-x86_64.refleak/build/Lib/multiprocessing/process.py", line 320, in _bootstrap
    self.run()
    ~~~~~~~~^^
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-x86_64.refleak/build/Lib/multiprocessing/process.py", line 108, in run
    self._target(*self._args, **self._kwargs)
    ~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-x86_64.refleak/build/Lib/test/_test_multiprocessing.py", line 524, in _sleep_some_event
    time.sleep(100)
    ~~~~~~~~~~^^^^^
KeyboardInterrupt
k


Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-x86_64.refleak/build/Lib/contextlib.py", line 85, in inner
    return func(*args, **kwds)
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-x86_64.refleak/build/Lib/test/_test_multiprocessing.py", line 596, in test_interrupt
    exitcode = self._kill_process(multiprocessing.Process.interrupt)
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-x86_64.refleak/build/Lib/contextlib.py", line 85, in inner
    return func(*args, **kwds)
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-x86_64.refleak/build/Lib/test/_test_multiprocessing.py", line 577, in _kill_process
    self.assertEqual(join(), None)
                     ~~~~^^
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-x86_64.refleak/build/Lib/test/_test_multiprocessing.py", line 250, in __call__
    return self.func(*args, **kwds)
           ~~~~~~~~~^^^^^^^^^^^^^^^
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-x86_64.refleak/build/Lib/multiprocessing/process.py", line 156, in join
    res = self._popen.wait(timeout)
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-x86_64.refleak/build/Lib/multiprocessing/popen_fork.py", line 44, in wait
    return self.poll(os.WNOHANG if timeout == 0.0 else 0)
           ~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-x86_64.refleak/build/Lib/multiprocessing/popen_fork.py", line 28, in poll
    pid, sts = os.waitpid(self.pid, flag)
               ~~~~~~~~~~^^^^^^^^^^^^^^^^
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-x86_64.refleak/build/Lib/test/_test_multiprocessing.py", line 573, in handler
    raise RuntimeError('join took too long: %s' % p)
RuntimeError: join took too long: <Process name='Process-6' pid=2441711 parent=2441704 started daemon>


Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-x86_64.refleak/build/Lib/contextlib.py", line 85, in inner
    return func(*args, **kwds)
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-x86_64.refleak/build/Lib/test/_test_multiprocessing.py", line 596, in test_interrupt
    exitcode = self._kill_process(multiprocessing.Process.interrupt)
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-x86_64.refleak/build/Lib/contextlib.py", line 85, in inner
    return func(*args, **kwds)
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-x86_64.refleak/build/Lib/test/_test_multiprocessing.py", line 577, in _kill_process
    self.assertEqual(join(), None)
                     ~~~~^^
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-x86_64.refleak/build/Lib/test/_test_multiprocessing.py", line 250, in __call__
    return self.func(*args, **kwds)
           ~~~~~~~~~^^^^^^^^^^^^^^^
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-x86_64.refleak/build/Lib/multiprocessing/process.py", line 156, in join
    res = self._popen.wait(timeout)
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-x86_64.refleak/build/Lib/multiprocessing/popen_fork.py", line 44, in wait
    return self.poll(os.WNOHANG if timeout == 0.0 else 0)
           ~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-x86_64.refleak/build/Lib/multiprocessing/popen_fork.py", line 28, in poll
    pid, sts = os.waitpid(self.pid, flag)
               ~~~~~~~~~~^^^^^^^^^^^^^^^^
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-x86_64.refleak/build/Lib/test/_test_multiprocessing.py", line 573, in handler
    raise RuntimeError('join took too long: %s' % p)
RuntimeError: join took too long: <Process name='Process-150' pid=2428123 parent=2426671 started daemon>

vstinner pushed a commit that referenced this pull request Nov 11, 2025
[3.13] gh-141004: document Py_INFINITY and Py_NAN macros (GH-141145) (#…
05e7b0d 
…141400)

(cherry picked from commit d694474)

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
vstinner pushed a commit that referenced this pull request Nov 11, 2025
[3.14] gh-141004: document Py_INFINITY and Py_NAN macros (GH-141145) (#…
8b94940 
…141399)

(cherry picked from commit d694474)

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
StanFromIreland added a commit to StanFromIreland/cpython that referenced this pull request Dec 6, 2025
pythongh-141004: document Py_INFINITY and Py_NAN macros (python#141145)
af9e8c7 
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

StanFromIreland StanFromIreland left review comments
ZeroIntensity ZeroIntensity approved these changes
vstinner Awaiting requested review from vstinner

Assignees

vstinner

Labels

docs Documentation in the Doc dir skip news

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL