Repository navigation
gh-141376: Remove exceptions from make smelly - #141392
Merged
encukou merged 4 commits intoNov 14, 2025
Merged
encukou merged 4 commits into
encukou merged 4 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
These exceptions were added in python#23423
I'm not sure if these are still needed
Copy link
Copy Markdown
Member
|
make smelly failed with: Smelly symbol: _AsyncioDebug (type: D). I wrote #141397 to rename this symbol. |
Sorry, something went wrong.
encukou
marked this pull request as ready for review
November 12, 2025 12:29
vstinner
approved these changes
Nov 12, 2025
vstinner
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM. I don't recall where _init and _fini functions were defined, but it seems like they are gone.
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Do you want to review #141394? That way I wouldn't need to handle the conflicts :) |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Let's do this first then :) |
Sorry, something went wrong.
StanFromIreland
pushed a commit
to StanFromIreland/cpython
that referenced
this pull request
Dec 6, 2025
* Don't ignore initialized data and BSS * Remove exceptions for _init and _fini
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dear CI: which of these are still needed?