GH-65961: Stop setting or using __package__ on modules - #142046
Closed
brettcannon wants to merge 8 commits into
Closed
GH-65961: Stop setting or using __package__ on modules#142046brettcannon wants to merge 8 commits into
brettcannon wants to merge 8 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
```
21 tests altered the execution environment (env changed):
test_logging test_pathlib test_profile test_pty test_pulldom
test_pwd test_pyclbr test_pyexpat test_pyrepl test_pystats
test_resource test_rlcompleter test_robotparser test_sax
test_sched test_secrets test_select test_set test_shlex test_str
test_thread
5 tests failed:
test_capi test_cmd_line_script test_importlib test_repl
test_sysconfig
```
Copy link
Copy Markdown
Member
Author
|
Currently a draft until the test_capi failure can somehow be resolved as I have no idea how what I'm doing is the direct cause of the failure. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
#142055 is an alternative to this PR where __package__ is no longer set, but is still supported. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Yet again this project gets postponed, this time thanks to pip: https://github.com/pypa/pip/blob/36987b0c31b97ffb9fb7949ded628e9a6b10c016/src/pip/__main__.py#L13 |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
The test_capi test failure is still weird, regardless, but this PR is now dead in the water. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📚 Documentation preview 📚: https://cpython-previews--142046.org.readthedocs.build/