GH-65961: Stop setting __package__ on modules - #142055
Closed
brettcannon wants to merge 5 commits into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
This is an alternative to #142046 which doesn't even support using __package__. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
This is a draft PR until either someone can tell me what's going on with test_capi or a rip the test out because I don't see how I'm causing the failure in either this PR and #142046 . |
Sorry, something went wrong.
… into __package__-optional
ncoghlan
approved these changes
Nov 28, 2025
ncoghlan
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM! Just one minor cosmetic comment on the docs.
Sorry, something went wrong.
Comment thread
Doc/reference/datamodel.rst
Outdated
Co-authored-by: Alyssa Coghlan <ncoghlan@gmail.com>
Copy link
Copy Markdown
Member
Author
|
Unfortunately it looks like pip didn't get the memo about this upcoming change: https://github.com/pypa/pip/blob/36987b0c31b97ffb9fb7949ded628e9a6b10c016/src/pip/__main__.py#L13 |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📚 Documentation preview 📚: https://cpython-previews--142055.org.readthedocs.build/