Repository navigation
Make RESUME monitoring more readable and robust - #142136
Merged
markshannon merged 3 commits intoDec 16, 2025
Merged
markshannon merged 3 commits into
markshannon merged 3 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
We make the code for the monitoring of PY_START and PY_RESUME events triggered by the RESUME opcode more readable and maintainable by not relying on some obscure logic on the value of oparg that can easily break if the event IDs are ever changed in the future.
markshannon
approved these changes
Dec 1, 2025
markshannon
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Thanks. That's a lot more readable.
Sorry, something went wrong.
Copy link
Copy Markdown
|
All commit authors signed the Contributor License Agreement. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
@P403n1x87 you'll need to sign the CLA before I can merge this. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
Ah it looks like I signed the (now legacy) one in 2021. Signed the new CLA. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We make the code for the monitoring of PY_START and PY_RESUME events triggered by the RESUME opcode more readable and maintainable by not relying on some obscure logic on the value of oparg that can easily break if the event IDs are ever changed in the future.