FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Make RESUME monitoring more readable and robust by P403n1x87 · Pull Request #142136 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

Make RESUME monitoring more readable and robust #142136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
markshannon merged 3 commits into from
Dec 16, 2025
Conversation 4 Commits 3 Checks 66 Files changed
Merged

Make RESUME monitoring more readable and robust #142136

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
59506ca
Make RESUME monitoring more readable and robust
P403n1x87 Dec 1, 2025
cff2132
add regen result
P403n1x87 Dec 1, 2025
984f795
Merge branch 'main' into start-resume-events-coded-properly
P403n1x87 Dec 16, 2025
File filter

Filter by extension

Filter by extension .c  (1) All 1 file type selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
Next Next commit
Make RESUME monitoring more readable and robust 
We make the code for the monitoring of PY_START and PY_RESUME events
triggered by the RESUME opcode more readable and maintainable by
not relying on some obscure logic on the value of oparg that can
easily break if the event IDs are ever changed in the future.
  • Loading branch information
P403n1x87 committed Dec 1, 2025
commit 59506ca06c54944df1eb25b16623c2a6b8e28c04
2 changes: 1 addition & 1 deletion Python/bytecodes.c
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -240,7 +240,7 @@ dummy_func(

op(_MONITOR_RESUME, (--)) {
int err = _Py_call_instrumentation(
tstate, oparg > 0, frame, this_instr);
tstate, oparg == 0 ? PY_MONITORING_EVENT_PY_START : PY_MONITORING_EVENT_PY_RESUME, frame, this_instr);
ERROR_IF(err);
if (frame->instr_ptr != this_instr) {
/* Instrumentation has jumped */
Expand Down
Loading
Back | FazBrowse Home | New Git URL