FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-140125: Increase object recursion depth for `test_json` from 200k to 500k by zanieb · Pull Request #142226 · python/cpython · GitHub

/ cpython Public

gh-140125: Increase object recursion depth for test_json from 200k to 500k - #142226

Merged
vstinner merged 2 commits into
python:mainfrom
zanieb:zb/test_json_rec
Dec 8, 2025
ConversationCommits (2)ChecksFiles changed
Merged

gh-140125: Increase object recursion depth for test_json from 200k to 500k#142226
vstinner merged 2 commits into
python:mainfrom
zanieb:zb/test_json_rec

Conversation

zanieb commented Dec 3, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

It appears increasing this recursion depth of the object resolves the issue where it can fail to hit the stack limit on macOS during PGO.

The PGO test runtime seemed unaffected on macOS and the test runtime in CI here seems within noise.

bedevere-app Bot added the tests Tests in the Lib/test dir label Dec 3, 2025
bedevere-app Bot mentioned this pull request Dec 3, 2025
Closed

zanieb commented Dec 4, 2025

Copy link
Copy Markdown
Contributor Author

From some microbenchmarks, this adds like 80ms or so on my machine, which seems negligible.

zanieb changed the title gh-140125: Increase recursion depth for test_json from 200k to 500k gh-140125: Increase object recursion depth for test_json from 200k to 500k Dec 4, 2025
zanieb requested a review from markshannon December 4, 2025 18:53
zanieb marked this pull request as ready for review December 4, 2025 18:53
zanieb requested a review from vstinner December 5, 2025 13:58
vstinner approved these changes Dec 5, 2025
View reviewed changes

vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

Comment thread Lib/test/test_json/test_recursion.py Outdated
Use _ consistently
3394248 
Co-authored-by: Victor Stinner <vstinner@python.org>
vstinner added the needs backport to 3.14 bugs and security fixes label Dec 8, 2025
vstinner merged commit e3539e9 into python:main Dec 8, 2025
46 checks passed

miss-islington-app Bot commented Dec 8, 2025

Copy link
Copy Markdown

Thanks @zanieb for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 8, 2025
pythongh-140125: Increase object recursion depth for test_json from…
2964a23 
… 200k to 500k (pythonGH-142226)

(cherry picked from commit e3539e9)

Co-authored-by: Zanie Blue <contact@zanie.dev>
Co-authored-by: Victor Stinner <vstinner@python.org>

bedevere-app Bot commented Dec 8, 2025

Copy link
Copy Markdown

GH-142416 is a backport of this pull request to the 3.14 branch.

bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Dec 8, 2025

vstinner commented Dec 8, 2025

Copy link
Copy Markdown
Member

@zanieb: Merged, thanks. I backported the change to 3.14 since you wrote that 3.14.1 is also affected by the issue. I don't think that 3.13 needs a backported. Correct me if I'm wrong.

zanieb commented Dec 8, 2025

Copy link
Copy Markdown
Contributor Author

That's correct. Thank you for backporting <3 I was just coming to ask for that

vstinner added a commit that referenced this pull request Dec 8, 2025
[3.14] gh-140125: Increase object recursion depth for test_json fro…
9bb27cd 
…m 200k to 500k (GH-142226) (#142416)

gh-140125: Increase object recursion depth for `test_json` from 200k to 500k (GH-142226)
(cherry picked from commit e3539e9)

Co-authored-by: Zanie Blue <contact@zanie.dev>
Co-authored-by: Victor Stinner <vstinner@python.org>
zanieb added a commit to astral-sh/python-build-standalone that referenced this pull request May 2, 2026
Ignore test_xml_etree_c under PGO
6421c5e 
This looks similar to python/cpython#142226
This was referenced May 2, 2026
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

vstinner vstinner approved these changes
markshannon Awaiting requested review from markshannon

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL