FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-149285: Increase recursion depth for `test_xml_etree` from 150k to 500k by zanieb · Pull Request #149286 · python/cpython · GitHub

/ cpython Public

gh-149285: Increase recursion depth for test_xml_etree from 150k to 500k - #149286

Merged
JelleZijlstra merged 1 commit into
python:mainfrom
zanieb:zb/149285
May 2, 2026
ConversationCommits (1)ChecksFiles changed
Merged

gh-149285: Increase recursion depth for test_xml_etree from 150k to 500k#149286
JelleZijlstra merged 1 commit into
python:mainfrom
zanieb:zb/149285

Conversation

zanieb commented May 2, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

bedevere-app Bot added the tests Tests in the Lib/test dir label May 2, 2026
bedevere-app Bot mentioned this pull request May 2, 2026
Closed
zanieb added skip news needs backport to 3.14 bugs and security fixes labels May 2, 2026
StanFromIreland reviewed May 2, 2026
View reviewed changes

StanFromIreland left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I was worried about this, I think just removing the assert is better, IIRC 500_000 is quite slow to build.

zanieb commented May 2, 2026

Copy link
Copy Markdown
Contributor Author

I don't think it's actually too slow, let me pull some benchmarks to confirm though.

zanieb commented May 2, 2026

Copy link
Copy Markdown
Contributor Author

Just running the test case with hyperfine I get

150k: 0.066s ± 0.000s                                                                                 
500k: 0.135s ± 0.002s

which is small enough to be insignificant in the larger test suite

StanFromIreland commented May 2, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

I must have been mis-remebering, seems fine to me!

zanieb marked this pull request as ready for review May 2, 2026 15:59
zanieb mentioned this pull request May 2, 2026
Merged
JelleZijlstra merged commit b1d6231 into python:main May 2, 2026
60 checks passed

miss-islington-app Bot commented May 2, 2026

Copy link
Copy Markdown

Thanks @zanieb for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

bedevere-app Bot commented May 2, 2026

Copy link
Copy Markdown

GH-149287 is a backport of this pull request to the 3.14 branch.

bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label May 2, 2026
JelleZijlstra pushed a commit that referenced this pull request May 2, 2026
[3.14] gh-149285: Increase recursion depth for test_xml_etree from …
644f94c 
…150k to 500k (GH-149286) (#149287)

(cherry picked from commit b1d6231)

Co-authored-by: Zanie Blue <contact@zanie.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

StanFromIreland StanFromIreland left review comments
JelleZijlstra JelleZijlstra approved these changes

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL