gh-138122: Extend binary profiling format with full source location and opcode - #143088
gh-138122: Extend binary profiling format with full source location and opcode#143088pablogsal merged 5 commits into
Conversation
Sorry, something went wrong.
|
@lkollar smaller PR here to add opcode and location support to the file format. Most of the bulk is tests + docs update. |
Sorry, something went wrong.
…tion and opcode Add end_lineno, column, end_column, and opcode fields to frame entries. Uses delta encoding for end positions to minimize file size. reader, writer, tests, and documentation.
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
lkollar
left a comment
There was a problem hiding this comment.
This looks great, just a couple of minor things.
Sorry, something went wrong.
| f"Thread ({interp_id}, {thread_id}), sample {i}, " | ||
| f"frame {j}: opcode mismatch " | ||
| f"(expected {exp_frame['opcode']}, got {act_frame['opcode']})", | ||
| ) |
There was a problem hiding this comment.
This is a long and duplicate list, that's not very dry, I wrote pablogsal#119
Sorry, something went wrong.
There was a problem hiding this comment.
Thanks a lot @StanFromIreland !
Sorry, something went wrong.
StanFromIreland
left a comment
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
Add end_lineno, column, end_column, and opcode fields to frame entries.
Uses delta encoding for end positions to minimize file size.
reader, writer, tests, and documentation.