FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-138122: Extend binary profiling format with full source location and opcode by pablogsal · Pull Request #143088 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-138122: Extend binary profiling format with full source location and opcode #143088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pablogsal merged 5 commits into from
Dec 24, 2025
Conversation 10 Commits 5 Checks 44 Files changed
Merged

gh-138122: Extend binary profiling format with full source location and opcode #143088

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
bb4129f
gh-138122: Extend binary profiling format with full source location a…
pablogsal Dec 23, 2025
2b220c0
Update profiling_binary_format.md
pablogsal Dec 23, 2025
e14acbf
Address feedback
pablogsal Dec 24, 2025
fd20570
DRY
StanFromIreland Dec 24, 2025
8a313bc
Merge pull request #119 from StanFromIreland/tachyon-binary-file-refux
pablogsal Dec 24, 2025
File filter

Filter by extension

Filter by extension .c  (1) All 1 file type selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
Prev Previous commit
Next Next commit
Address feedback
  • Loading branch information
pablogsal committed Dec 24, 2025
commit e14acbf3ddee7babc78a3e90b69882921e37f55f
36 changes: 19 additions & 17 deletions Modules/_remote_debugging/binary_io_writer.c
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@

#include "binary_io.h"
#include "_remote_debugging.h"
#include "pycore_opcode_utils.h" // MAX_REAL_OPCODE
#include <string.h>

#ifdef HAVE_ZSTD
Expand Down Expand Up @@ -410,12 +411,13 @@ writer_intern_string(BinaryWriter *writer, PyObject *string, uint32_t *index)
}

static inline int
writer_intern_frame(BinaryWriter *writer, uint32_t filename_idx, uint32_t funcname_idx,
int32_t lineno, int32_t end_lineno, int32_t column, int32_t end_column,
uint8_t opcode, uint32_t *index)
writer_intern_frame(BinaryWriter *writer, const FrameEntry *entry, uint32_t *index)
{
FrameKey lookup_key = {
filename_idx, funcname_idx, lineno, end_lineno, column, end_column, opcode
entry->filename_idx, entry->funcname_idx,
entry->lineno, entry->end_lineno,
entry->column, entry->end_column,
entry->opcode
};

void *existing = _Py_hashtable_get(writer->frame_hash, &lookup_key);
Expand All @@ -437,14 +439,7 @@ writer_intern_frame(BinaryWriter *writer, uint32_t filename_idx, uint32_t funcna
*key = lookup_key;

*index = (uint32_t)writer->frame_count;
FrameEntry *fe = &writer->frame_entries[writer->frame_count];
fe->filename_idx = filename_idx;
fe->funcname_idx = funcname_idx;
fe->lineno = lineno;
fe->end_lineno = end_lineno;
fe->column = column;
fe->end_column = end_column;
fe->opcode = opcode;
writer->frame_entries[writer->frame_count] = *entry;

if (_Py_hashtable_set(writer->frame_hash, key, (void *)(uintptr_t)(*index + 1)) < 0) {
PyMem_Free(key);
Expand Down Expand Up @@ -853,7 +848,7 @@ build_frame_stack(BinaryWriter *writer, PyObject *frame_list,

if (location != Py_None) {
/* LocationInfo is a struct sequence or tuple with:
* (lineno, end_lineno, col_offset, end_col_offset) */
* (lineno, end_lineno, column, end_column) */
PyObject *lineno_obj = PyTuple_Check(location) ?
PyTuple_GET_ITEM(location, 0) :
PyStructSequence_GET_ITEM(location, 0);
Expand All @@ -880,7 +875,7 @@ build_frame_stack(BinaryWriter *writer, PyObject *frame_list,
if (UNLIKELY(PyErr_Occurred() != NULL)) {
PyErr_Clear();
opcode = OPCODE_NONE;
} else if (opcode_long >= 0 && opcode_long <= 254) {
} else if (opcode_long >= 0 && opcode_long <= MAX_REAL_OPCODE) {
opcode = (uint8_t)opcode_long;
}
}
Expand All @@ -898,10 +893,17 @@ build_frame_stack(BinaryWriter *writer, PyObject *frame_list,
}

/* Intern frame with full location info */
FrameEntry frame_entry = {
.filename_idx = filename_idx,
.funcname_idx = funcname_idx,
.lineno = lineno,
.end_lineno = end_lineno,
.column = column,
.end_column = end_column,
.opcode = opcode
};
uint32_t frame_idx;
if (writer_intern_frame(writer, filename_idx, funcname_idx,
lineno, end_lineno, column, end_column,
opcode, &frame_idx) < 0) {
if (writer_intern_frame(writer, &frame_entry, &frame_idx) < 0) {
return -1;
}

Expand Down
Loading
Back | FazBrowse Home | New Git URL