FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-143121: Skip test that leak threads under TSan by colesbury · Pull Request #143125 · python/cpython · GitHub

/ cpython Public

gh-143121: Skip test that leak threads under TSan - #143125

Merged
colesbury merged 1 commit into
python:mainfrom
colesbury:gh-143121-multiprocessing-thread-leaks
Dec 24, 2025
ConversationCommits (1)ChecksFiles changed
Merged

gh-143121: Skip test that leak threads under TSan#143125
colesbury merged 1 commit into
python:mainfrom
colesbury:gh-143121-multiprocessing-thread-leaks

Conversation

colesbury commented Dec 23, 2025 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

TSan reports that these tests leak threads. We currently suppress the warning in a suppressions file. Skipping these tests instead of relying on the suppression file will allow us to catch regressions in other test cases.

bedevere-app Bot added the tests Tests in the Lib/test dir label Dec 23, 2025
colesbury added skip news and removed tests Tests in the Lib/test dir labels Dec 23, 2025
bedevere-app Bot mentioned this pull request Dec 23, 2025
Closed
colesbury added the tests Tests in the Lib/test dir label Dec 23, 2025
colesbury marked this pull request as ready for review December 23, 2025 23:48
colesbury requested a review from gpshead as a code owner December 23, 2025 23:48
colesbury requested a review from mpage December 23, 2025 23:48
gpshead added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Dec 24, 2025
colesbury merged commit 4ee6929 into python:main Dec 24, 2025
62 checks passed
colesbury deleted the gh-143121-multiprocessing-thread-leaks branch December 24, 2025 13:02

miss-islington-app Bot commented Dec 24, 2025

Copy link
Copy Markdown

Thanks @colesbury for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

miss-islington-app Bot commented Dec 24, 2025

Copy link
Copy Markdown

Sorry, @colesbury, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 4ee6929d606fa7b976eba229de24219f0edac3d7 3.14

miss-islington-app Bot commented Dec 24, 2025

Copy link
Copy Markdown

Sorry, @colesbury, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 4ee6929d606fa7b976eba229de24219f0edac3d7 3.13

colesbury added a commit to colesbury/cpython that referenced this pull request Dec 24, 2025
[3.14] pythongh-143121: Skip test that leak threads under TSan (pytho…
8b99792 
…ngh-143125)

(cherry picked from commit 4ee6929)

Co-authored-by: Sam Gross <colesbury@gmail.com>

bedevere-app Bot commented Dec 24, 2025

Copy link
Copy Markdown

GH-143141 is a backport of this pull request to the 3.14 branch.

bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Dec 24, 2025
colesbury added a commit to colesbury/cpython that referenced this pull request Dec 24, 2025
[3.13] pythongh-143121: Skip test that leak threads under TSan (pytho…
6fc349f 
…ngh-143125)

(cherry picked from commit 4ee6929)

Co-authored-by: Sam Gross <colesbury@gmail.com>

bedevere-app Bot commented Dec 24, 2025

Copy link
Copy Markdown

GH-143142 is a backport of this pull request to the 3.13 branch.

bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Dec 24, 2025
colesbury added a commit that referenced this pull request Dec 24, 2025
[3.13] gh-143121: Skip test that leak threads under TSan (gh-143125) (#…
86504f2 
…143142)

(cherry picked from commit 4ee6929)
colesbury added a commit that referenced this pull request Dec 24, 2025
[3.14] gh-143121: Skip test that leak threads under TSan (gh-143125) (#…
b921374 
…143141)

(cherry picked from commit 4ee6929)
colesbury mentioned this pull request Jan 6, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

gpshead gpshead approved these changes
mpage Awaiting requested review from mpage

Assignees

colesbury

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL