gh-117657: Remove remaining TSan suppressions - #143499
Merged
colesbury merged 3 commits intoJan 7, 2026
Merged
Conversation
Copy link
Copy Markdown
Contributor
Author
|
Thread leaks were fixed (or skipped) in:
I'm not sure when we fixed _PyObject_TryGetInstanceAttribute(), but I've been running the test suite repeatedly locally without suppressions and haven't see any races reported for it. |
Sorry, something went wrong.
Yhg1s
approved these changes
Jan 6, 2026
Comment thread
Tools/tsan/suppressions_free_threading.txt
| # the free-threaded build. | ||
| # | ||
| # reference: https://github.com/google/sanitizers/wiki/ThreadSanitizerSuppressions | ||
|
|
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Let's add a "this page intentionally left blank" comment, to make it clear this really is meant to be empty but we don't want to delete it because tooling might be expect it to exist in 3.15 like it did in 3.14. (I assume that's why you aren't deleting it.)
Sorry, something went wrong.
Also add instructions for adding new suppressions in case we need to do that in the future.
colesbury
enabled auto-merge (squash)
January 7, 2026 17:03
thunder-coding
pushed a commit
to thunder-coding/cpython
that referenced
this pull request
Feb 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.