| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
This makes the check much faster. It also found 4 additional undocumented APIs, as it does not match substrings (e.g. documenting `PyErr_WarnEx` doesn't mean that `PyErr_Warn` is documented)
There was a problem hiding this comment.
Thanks, this looks pretty good as-is.
One extra thing I would like to do is run the script on docs PRs, since a name being documented while also being in ignored_c_api.txt will cause it to fail. So, if someone merges new documentation without updating ignored_c_api.txt, we'll see blocking failures on all C code PRs until we fix it. I haven't looked too closely at the GHA for change detection, but if you see an easy way to do that, would you mind doing it in this PR?
Sorry, something went wrong.
|
I'm not much of a GHA expert, so I'd leave changes to that to a separate PR. |
Sorry, something went wrong.
There was a problem hiding this comment.
Ok, let's just merge this as-is.
Sorry, something went wrong.
See #143573. |
Sorry, something went wrong.
|
Thanks @encukou for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
Sorry, something went wrong.
|
Sorry, @encukou, I could not cleanly backport this to 3.14 due to a conflict. cherry_picker 234a15dc4ec2d8f8ababea91532ebe896a96387a 3.14 |
Sorry, something went wrong.
|
Sorry, @encukou, I could not cleanly backport this to 3.13 due to a conflict. cherry_picker 234a15dc4ec2d8f8ababea91532ebe896a96387a 3.13 |
Sorry, something went wrong.
) - Gather all documented names into a set in a single pass. This makes the check much faster. - Do not match substrings (e.g. documenting `PyErr_WarnEx` doesn't mean that `PyErr_Warn` is documented) - Consider `PY`-prefixed names (a lot of old macros use this) (cherry picked from commit 234a15d)
|
GH-143593 is a backport of this pull request to the 3.14 branch. |
Sorry, something went wrong.
- Gather all documented names into a set in a single pass. This makes the check much faster. - Do not match substrings (e.g. documenting `PyErr_WarnEx` doesn't mean that `PyErr_Warn` is documented) - Consider `PY`-prefixed names (a lot of old macros use this) (cherry picked from commit 234a15d)
|
GH-143594 is a backport of this pull request to the 3.13 branch. |
Sorry, something went wrong.
) - Gather all documented names into a set in a single pass. This makes the check much faster. - Do not match substrings (e.g. documenting `PyErr_WarnEx` doesn't mean that `PyErr_Warn` is documented) - Consider `PY`-prefixed names (a lot of old macros use this) (cherry picked from commit 234a15d)
) - Gather all documented names into a set in a single pass. This makes the check much faster. - Do not match substrings (e.g. documenting `PyErr_WarnEx` doesn't mean that `PyErr_Warn` is documented) - Consider `PY`-prefixed names (a lot of old macros use this) (cherry picked from commit 234a15d)
⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️Hi! The buildbot x86-64 MacOS Intel NoGIL 3.13 (tier-2) has failed when building commit b06ef5b. What do you need to do:
You can take a look at the buildbot page here: https://buildbot.python.org/#/builders/1449/builds/1695 Failed tests:
Failed subtests:
Summary of the results of the build (if available): == Click to see traceback logsTraceback (most recent call last):
File "/Users/buildbot/buildarea/3.13.itamaro-macos-intel-aws.nogil/build/Lib/test/_test_multiprocessing.py", line 1493, in test_repr_rlock
self.assertEqual('<RLock(SomeOtherThread, nonzero)>', repr(lock))
~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: '<RLock(SomeOtherThread, nonzero)>' != '<RLock(None, 0)>'
- <RLock(SomeOtherThread, nonzero)>
+ <RLock(None, 0)>
|
Sorry, something went wrong.
- Gather all documented names into a set in a single pass. This makes the check much faster. - Do not match substrings (e.g. documenting `PyErr_WarnEx` doesn't mean that `PyErr_Warn` is documented) - Consider `PY`-prefixed names (a lot of old macros use this)
- Gather all documented names into a set in a single pass. This makes the check much faster. - Do not match substrings (e.g. documenting `PyErr_WarnEx` doesn't mean that `PyErr_Warn` is documented) - Consider `PY`-prefixed names (a lot of old macros use this)
| Back | FazBrowse Home | New Git URL |
Gather all documented names into a set in a single pass. This makes the check much faster.
Do not match substrings (e.g. documenting PyErr_WarnEx doesn't mean that PyErr_Warn is documented)
Consider PY-prefixed names (a lot of old macros use this)