| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
There was a problem hiding this comment.
This makes sense to me, but I'd like one of the GHA experts to have a look.
Sorry, something went wrong.
|
Personally, I've been leaning towards having a single workflow tool target invocation per job. In this case it's one make command (I've implemented my reusable-tox.yml thing around the same approach and a it turned out to be a pretty powerful strategy). So yes, it's a good idea — it can run a check that would otherwise be skipped, sometimes. But I also foresee better responsiveness even in full runs. This could be taken farther at some point (follow-ups) but it's well-scoped as it is. One thing I'd ask, though would be moving the new job into a reusable-*.yml module so this doesn't contribute to cluttering the huge YAML file more than it is already. No other comments otherwise.
In that case, I'd maybe reduce the job timeout to 5 minutes or less. This tends to improve responsiveness too, plus catch problems with sudden slowdowns w/o wasting too much CPU. |
Sorry, something went wrong.
Done :-) |
Sorry, something went wrong.
Co-authored-by: 🇺🇦 Sviatoslav Sydorenko (Святослав Сидоренко) <wk.cvs.github@sydorenko.org.ua>
There was a problem hiding this comment.
I think this is ready, I left a style note, though. But that's inconsistent across the CI definitions anyway, so not important.
Sorry, something went wrong.
|
As I replied to the comment mentioned in the OP:
Here's the code to parse Intersphinx inventory: main...encukou:cpython:doccheck-intersphinx Would it be possible to hook up GHA so that the Doc/build/html/objects.inv file generated in the “Doc build” step is accessible? And perhaps use a slightly older one if docs weren't rebuilt? |
Sorry, something went wrong.
Yes we could, we can upload the artifact in the docs build and run the c-api check when it is available. Edit: Funnily enough, here is an example of just that: #143742 Since it is not necessary yet, I suggest it is done in a future PR. |
Sorry, something went wrong.
|
I can open a PR on your fork against your branch with the changes when this is merged. |
Sorry, something went wrong.
|
Thank you! Feel free to send PRs to my branch. Or merge to your branch and send the CPython PR from that. |
Sorry, something went wrong.
Or from sphinx.ext.intersphinx import fetch_inventory if Sphinx is available in that env. I'm using it in a hacky static website that shows tables with linckable objects on the web: https://webknjaz.github.io/intersphinx-untangled/. |
Sorry, something went wrong.
|
fetch_inventory is undocumented; it needs a Sphinx app and returns an Inventory which are both also undocumented. I don't think it's much of a win over zlib… (Are you sure your site works with the latest Sphinx?) |
Sorry, something went wrong.
Yeah, I was lazy and didn't pin versions. So it always pulls whatever's latest on PyPI (every three four hours): https://github.com/webknjaz/intersphinx-untangled/blob/dbb400751a169988d486495b160137fc2a594438/.github/workflows/build-gh-pages.yml#L26C48-L26C54. On that note, I just realized I'm passing a fake object in there (see a dozen lines below). YOLO! |
Sorry, something went wrong.
…ythonGH-143573) Co-authored-by: 🇺🇦 Sviatoslav Sydorenko (Святослав Сидоренко) <wk.cvs.github@sydorenko.org.ua>
|
GH-154464 is a backport of this pull request to the 3.14 branch. |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
As mentioned in #143564 (review) by @ZeroIntensity:
We could keep it in the check-generated-files job, but that would make it quite messy as all the other checks would have to be excluded in the case when only run-docs is true. And, to avoid having to configure, I run the script directly (since it uses PYTHON_FOR_REGEN anyway, there shouldn't be a difference).
On this PR, the new job ran in 13 seconds.