FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-143754: Modernize Tkinter docs by serhiy-storchaka · Pull Request #143841 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-143754: Modernize Tkinter docs - #143841

Merged
serhiy-storchaka merged 1 commit into
python:mainfrom
serhiy-storchaka:tkinter-master-slave-docs
Jan 19, 2026
ConversationCommits (1)ChecksFiles changed
Merged

gh-143754: Modernize Tkinter docs#143841
serhiy-storchaka merged 1 commit into
python:mainfrom
serhiy-storchaka:tkinter-master-slave-docs

Conversation

serhiy-storchaka commented Jan 14, 2026 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member

Use more up to date terminology instead of "master"/"slave" widgets where it is possible.

📚 Documentation preview 📚: https://cpython-previews--143841.org.readthedocs.build/

pythongh-143754: Modernize Tkinter docs
cd9ede3 
Use more up to date terminology instead of "master"/"slave" widgets
where it is possible.
serhiy-storchaka added docs Documentation in the Doc dir skip news needs backport to 3.13 only security fixes needs backport to 3.14 bugs and security fixes labels Jan 14, 2026
github-project-automation Bot moved this to Todo in Docs PRs Jan 14, 2026
bedevere-app Bot mentioned this pull request Jan 14, 2026
Closed

serhiy-storchaka commented Jan 14, 2026

Copy link
Copy Markdown
Member Author

I used the modern Tk documentation to update the Tkinter documentation.

serhiy-storchaka mentioned this pull request Jan 14, 2026
Merged
terryjreedy reviewed Jan 19, 2026
View reviewed changes
Comment thread Lib/tkinter/__init__.py
Comment on lines 2669 to 2670
width=amount - width of this widget in pixel
height=amount - height of this widget in pixel

terryjreedy Jan 19, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality
Suggested change
width=amount - width of this widget in pixel
height=amount - height of this widget in pixel
width=amount - width of this widget in pixels
height=amount - height of this widget in pixels

serhiy-storchaka Jan 19, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

There are other occurrences of "in pixel" in other places, so I think it is better to fix them in a separate PR.

serhiy-storchaka Jan 19, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

And, the Tk documentation says "in screen units", because not only pixels are supported. You can use millimeters or inches, etc.

terryjreedy reviewed Jan 19, 2026
View reviewed changes

terryjreedy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

approved except for pluralizing 'pixel'.

serhiy-storchaka merged commit 813fc7a into python:main Jan 19, 2026
58 checks passed
github-project-automation Bot moved this from Todo to Done in Docs PRs Jan 19, 2026

miss-islington-app Bot commented Jan 19, 2026

Copy link
Copy Markdown

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

serhiy-storchaka deleted the tkinter-master-slave-docs branch January 19, 2026 12:01
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 19, 2026
pythongh-143754: Modernize Tkinter docs (pythonGH-143841)
8dc032d 
Use more relevant terminology instead of "master"/"slave" widgets where possible.
(cherry picked from commit 813fc7a)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 19, 2026
pythongh-143754: Modernize Tkinter docs (pythonGH-143841)
5e494ba 
Use more relevant terminology instead of "master"/"slave" widgets where possible.
(cherry picked from commit 813fc7a)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>

bedevere-app Bot commented Jan 19, 2026

Copy link
Copy Markdown

GH-144032 is a backport of this pull request to the 3.14 branch.

bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Jan 19, 2026

bedevere-app Bot commented Jan 19, 2026

Copy link
Copy Markdown

GH-144033 is a backport of this pull request to the 3.13 branch.

bedevere-app Bot removed the needs backport to 3.13 only security fixes label Jan 19, 2026
serhiy-storchaka added a commit that referenced this pull request Jan 19, 2026
[3.13] gh-143754: Modernize Tkinter docs (GH-143841) (GH-144033)
48a8cd1 
Use more relevant terminology instead of "master"/"slave" widgets where possible.
(cherry picked from commit 813fc7a)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
serhiy-storchaka added a commit that referenced this pull request Jan 19, 2026
[3.14] gh-143754: Modernize Tkinter docs (GH-143841) (GH-144032)
5573df1 
Use more relevant terminology instead of "master"/"slave" widgets where possible.
(cherry picked from commit 813fc7a)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>

vstinner commented Jan 19, 2026

Copy link
Copy Markdown
Member

Nice change, thanks.

bedevere-bot commented Jan 19, 2026

Copy link
Copy Markdown

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Debian root 3.13 (tier-1) has failed when building commit 48a8cd1.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1441/builds/1736) and take a look at the build logs.
  4. Check if the failure is related to this commit (48a8cd1) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1441/builds/1736

Summary of the results of the build (if available):

==

Click to see traceback logs 
Traceback (most recent call last):
  File "/root/buildarea/3.13.angelico-debian-amd64/build/Lib/test/support/__init__.py", line 856, in gc_collect
    gc.collect()
ResourceWarning: unclosed file <_io.FileIO name=11 mode='wb' closefd=True>


Traceback (most recent call last):
  File "/root/buildarea/3.13.angelico-debian-amd64/build/Lib/test/support/__init__.py", line 856, in gc_collect
    gc.collect()
ResourceWarning: unclosed file <_io.FileIO name=13 mode='wb' closefd=True>

bedevere-bot commented Jan 19, 2026

Copy link
Copy Markdown

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot ARM64 MacOS M1 Refleaks NoGIL 3.13 (tier-2) has failed when building commit 48a8cd1.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1396/builds/1968) and take a look at the build logs.
  4. Check if the failure is related to this commit (48a8cd1) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1396/builds/1968

Failed tests:

  • test.test_multiprocessing_spawn.test_processes
  • test.test_multiprocessing_forkserver.test_processes

Failed subtests:

  • test_repr_rlock - test.test_multiprocessing_spawn.test_processes.WithProcessesTestLock.test_repr_rlock
  • test_repr_rlock - test.test_multiprocessing_forkserver.test_processes.WithProcessesTestLock.test_repr_rlock

Summary of the results of the build (if available):

==

Click to see traceback logs 
Traceback (most recent call last):
  File "/Users/buildbot/buildarea/3.13.itamaro-macos-arm64-aws.macos-with-brew.refleak.nogil/build/Lib/test/_test_multiprocessing.py", line 1493, in test_repr_rlock
    self.assertEqual('<RLock(SomeOtherThread, nonzero)>', repr(lock))
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: '<RLock(SomeOtherThread, nonzero)>' != '<RLock(None, 0)>'
- <RLock(SomeOtherThread, nonzero)>
+ <RLock(None, 0)>

thunder-coding pushed a commit to thunder-coding/cpython that referenced this pull request Feb 15, 2026
pythongh-143754: Modernize Tkinter docs (pythonGH-143841)
a4e5656 
Use more relevant terminology instead of "master"/"slave" widgets where possible.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

terryjreedy terryjreedy left review comments

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL