| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
|
The new stuff (on top of what is already in #143841) looks okay without closely examining every detail. |
Sorry, something went wrong.
|
I suggest we also:
|
Sorry, something went wrong.
|
To be nice, we should deprecate the old methods only when the new methods are available in all maintained Python versions, so the user can simply unconditionally switch to using the new methods. Since this change is just cosmetic, there is no need to even deprecate them in code. The code written 20 years ago will continue to work. We still test the *slaves() methods. This is why we need a separate implementation -- to notice when it stopped working on the Tk side. |
Sorry, something went wrong.
…and grid_content() They use Tk commands with new name like "pack content instead of old "pack slaves".
There was a problem hiding this comment.
Perhaps we could soft deprecate until then?
Anyway, thanks for the PR.
Sorry, something went wrong.
|
There is no module documentation where the soft deprecation could be written. The docstrins now say "Synonym for ...". This is an equivalent of soft deprecation. You should not use these methods in new code if you do not support Python 3.14, but you are not forced to make mass renaming. I expect that nobody will use the new methods in the next 3 years. |
Sorry, something went wrong.
…and grid_content() (pythonGH-143845) They use Tk commands with new name like "pack content instead of old "pack slaves".
| Back | FazBrowse Home | New Git URL |
They use Tk commands with new name like "pack content instead of old "pack slaves".
Based on top of #143841.
📚 Documentation preview 📚: https://cpython-previews--143845.org.readthedocs.build/