[3.14] gh-139588: Docs: fix PDF build - #145741
Merged
hugovk merged 2 commits intoMar 21, 2026
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 267e1c1149
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Sorry, something went wrong.
Comment thread
Doc/Makefile
Outdated
When running `make -j`, the `_ensure-sphinxcontrib-svg2pdfconverter` and `build` prerequisites of the `latex` target could execute in parallel. If `build` started before the venv was created by `_ensure-sphinxcontrib-svg2pdfconverter`, `sphinx-build` would not be found and the build would fail. Fix this by removing `build` from the prerequisites and invoking it explicitly from the recipe, ensuring the venv is fully set up before the Sphinx build begins.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partial cherry-pick from fc03cdc commit. It wouldn't apply cleanly automatically, because Doc/library/profiling.sampling.rst is not on 3.14 branch.
Problematic docs line:
cpython/Doc/library/datetime.rst
Line 161 in e765696
📚 Documentation preview 📚: https://cpython-previews--145741.org.readthedocs.build/