gh-139588: Docs: serialize latex prerequisites before running build - #151343
Merged
StanFromIreland merged 1 commit intoJun 11, 2026
Merged
gh-139588: Docs: serialize latex prerequisites before running build#151343StanFromIreland merged 1 commit into
StanFromIreland merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Adding _ensure-sphinxcontrib-svg2pdfconverter as a sibling prerequisite of build makes make -jN latex nondeterministic, because GNU Make may run both prerequisites in parallel. In that mode, build can start before the converter package (and even the venv it depends on) is installed, so the LaTeX doc build can fail intermittently with missing tooling even though the target is supposed to prepare it first.
m-aciek
requested review from
AA-Turner,
StanFromIreland and
hugovk
as code owners
June 11, 2026 14:10
2 tasks
StanFromIreland
approved these changes
Jun 11, 2026
StanFromIreland
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
Copy link
Copy Markdown
|
Thanks @m-aciek for the PR, and @StanFromIreland for merging it 🌮🎉.. I'm working now to backport this PR to: 3.15. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Dzięki! |
Sorry, something went wrong.
Copy link
Copy Markdown
|
GH-151352 is a backport of this pull request to the 3.15 branch. |
Sorry, something went wrong.
philthompson10
pushed a commit
to philthompson10/cpython
that referenced
this pull request
Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding _ensure-sphinxcontrib-svg2pdfconverter as a sibling prerequisite of build makes make -jN latex nondeterministic, because GNU Make may run both prerequisites in parallel. In that mode, build can start before the converter package (and even the venv it depends on) is installed, so the LaTeX doc build can fail intermittently with missing tooling even though the target is supposed to prepare it first.
This fixes a bug introduced in #145480.
Example faulty run. In this job build is invoked first, and then the installation of the required package. In effect in generated artifact there are no PDF images converted from SVGs.
Could it be please marked for a backport to 3.15?
This is already fixed for 3.14: #145741.